third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl - Issue 2471393004: bindings: Use forward declarations for wrapper types in dictionary_impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

Issue 2471393004: bindings: Use forward declarations for wrapper types in dictionary_impl (Closed)

Patch Set: WIP Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl ('K') | « third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl ('k') | third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

diff --git a/third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl b/third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

index 5fce8e03fbea44b39039f5c0f436ad439a166e5c..58a244516785378651966ce62cb2a2870c6f8420 100644

--- a/third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

+++ b/third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl

@@ -17,6 +17,7 @@ dictionary TestDictionary {

DOMString[] stringArrayMember;

sequence<DOMString> stringSequenceMember = [];

sequence<TestInterface> testInterfaceSequenceMember = [];

+ sequence<TestObject> testObjectSequenceMember;

bashi 2016/11/11 01:54:02 This tests the change. TestObject refers TestDicti

sequence<TestInterfaceGarbageCollected> testInterfaceGarbageCollectedSequenceMember = [];

TestEnum enumMember = "foo";

sequence<TestEnum> enumSequenceMember;