Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

Issue 2471353004: Implement AudioScheduledSourceNode (Closed)
Patch Set: Address review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h
index 2fcd6bd7372d437f6a1581987e3bc98c44e4c6c1..c9ce9d490a0f8a99cc971b2e25d176f8bb69f48b 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h
@@ -30,7 +30,7 @@
#define AudioScheduledSourceNode_h
#include "bindings/core/v8/ActiveScriptWrappable.h"
-#include "modules/webaudio/AudioSourceNode.h"
+#include "modules/webaudio/AudioNode.h"
namespace blink {
@@ -124,9 +124,10 @@ class AudioScheduledSourceHandler : public AudioHandler {
int m_playbackState;
};
-class AudioScheduledSourceNode : public AudioSourceNode,
+class AudioScheduledSourceNode : public AudioNode,
public ActiveScriptWrappable {
USING_GARBAGE_COLLECTED_MIXIN(AudioScheduledSourceNode);
+ DEFINE_WRAPPERTYPEINFO();
public:
void start(ExceptionState&);
@@ -140,7 +141,7 @@ class AudioScheduledSourceNode : public AudioSourceNode,
// ScriptWrappable:
bool hasPendingActivity() const final;
- DEFINE_INLINE_VIRTUAL_TRACE() { AudioSourceNode::trace(visitor); }
+ DEFINE_INLINE_VIRTUAL_TRACE() { AudioNode::trace(visitor); }
tkent 2016/12/05 23:34:45 Looks this function is unnecessary.
Raymond Toy 2016/12/06 00:04:00 Removing this causes the compiler to complain abou
tkent 2016/12/06 00:25:03 ActiveScriptWrappable is a GarbageCollectionMixin,
protected:
explicit AudioScheduledSourceNode(BaseAudioContext&);

Powered by Google App Engine
This is Rietveld 408576698