Implement AudioScheduledSourceNode

third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef AudioScheduledSourceNode_h
 #define AudioScheduledSourceNode_h
 
 #include "bindings/core/v8/ActiveScriptWrappable.h"
-#include "modules/webaudio/AudioSourceNode.h"
+#include "modules/webaudio/AudioNode.h"
 
 namespace blink {
 
 class BaseAudioContext;
 class AudioBus;
 
 class AudioScheduledSourceHandler : public AudioHandler {
  public:
   // These are the possible states an AudioScheduledSourceNode can be in:
   //
@@ skipping 73 matching lines @@
   double m_endTime;  // in seconds
 
   static const double UnknownTime;
 
  private:
   // This is accessed by both the main thread and audio thread.  Use the setter
   // and getter to protect the access to this.
   int m_playbackState;
 };
 
-class AudioScheduledSourceNode : public AudioSourceNode,
+class AudioScheduledSourceNode : public AudioNode,
                                  public ActiveScriptWrappable {
   USING_GARBAGE_COLLECTED_MIXIN(AudioScheduledSourceNode);
+  DEFINE_WRAPPERTYPEINFO();
 
  public:
   void start(ExceptionState&);
   void start(double when, ExceptionState&);
   void stop(ExceptionState&);
   void stop(double when, ExceptionState&);
 
   EventListener* onended();
   void setOnended(EventListener*);
 
   // ScriptWrappable:
   bool hasPendingActivity() const final;
 
-  DEFINE_INLINE_VIRTUAL_TRACE() { AudioSourceNode::trace(visitor); }
+  DEFINE_INLINE_VIRTUAL_TRACE() { AudioNode::trace(visitor); }

[tkent, 2016/12/05 23:34:45]

Looks this function is unnecessary.

[Raymond Toy, 2016/12/06 00:04:00]

Removing this causes the compiler to complain about the use of
USING_GARBAGE_COLLECTED_MIXIN(AudioScheduledSourceNode)

Does this mean I don't need USING_GARBAGE_COLLECTED_MIXIN either?

[tkent, 2016/12/06 00:25:03]

ActiveScriptWrappable is a GarbageCollectionMixin, and
USING_GARBAGE_COLLECTED_MIXIN is necessary.
I still don't understand why the compiler complains. Anyway it's ok to land this
as is.  I'm sorry for disturbing you.

 
  protected:
   explicit AudioScheduledSourceNode(BaseAudioContext&);
   AudioScheduledSourceHandler& audioScheduledSourceHandler() const;
 };
 
 }  // namespace blink
 
 #endif  // AudioScheduledSourceNode_h