Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2471263002: [Autofill] Add some missing types in autofill_metrics.cc (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
Reviewers:
rkaplow
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, asvitkine+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Add some missing types in autofill_metrics.cc BUG=653887 TEST=AutofillMetrics Committed: https://crrev.com/04e3a2ed54c326926be9cc0da552cac84f7469d3 Cr-Commit-Position: refs/heads/master@{#429550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M components/autofill/core/browser/autofill_metrics.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mathieu
Robert, would you like to have a look?
4 years, 1 month ago (2016-11-02 20:23:57 UTC) #5
rkaplow
lgtm
4 years, 1 month ago (2016-11-02 23:04:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471263002/1
4 years, 1 month ago (2016-11-03 13:07:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 13:12:16 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 13:14:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04e3a2ed54c326926be9cc0da552cac84f7469d3
Cr-Commit-Position: refs/heads/master@{#429550}

Powered by Google App Engine
This is Rietveld 408576698