[Autofill] Add some missing types in autofill_metrics.cc

components/autofill/core/browser/autofill_metrics.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/metrics/user_metrics.h"
 #include "base/time/time.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/common/form_data.h"
 
 namespace autofill {
 
 namespace {
 
+// Note: if adding an enum value here, update the corresponding description for
+// AutofillTypeQualityByFieldType in histograms.xml.
 enum FieldTypeGroupForMetrics {
   GROUP_AMBIGUOUS = 0,
   GROUP_NAME,
   GROUP_COMPANY,
   GROUP_ADDRESS_LINE_1,
   GROUP_ADDRESS_LINE_2,
   GROUP_ADDRESS_CITY,
   GROUP_ADDRESS_STATE,
   GROUP_ADDRESS_ZIP,
   GROUP_ADDRESS_COUNTRY,
   GROUP_PHONE,
   GROUP_FAX,  // Deprecated.
   GROUP_EMAIL,
   GROUP_CREDIT_CARD_NAME,
   GROUP_CREDIT_CARD_NUMBER,
   GROUP_CREDIT_CARD_DATE,
   GROUP_CREDIT_CARD_TYPE,
   GROUP_PASSWORD,
   GROUP_ADDRESS_LINE_3,
   GROUP_USERNAME,
   GROUP_STREET_ADDRESS,
+  GROUP_CREDIT_CARD_VERIFICATION,
   NUM_FIELD_TYPE_GROUPS_FOR_METRICS
 };
 
 }  // namespace
 
 // First, translates |field_type| to the corresponding logical |group| from
 // |FieldTypeGroupForMetrics|.  Then, interpolates this with the given |metric|,
 // which should be in the range [0, |num_possible_metrics|).
 // Returns the interpolated index.
 //
@@ skipping 56 matching lines @@
         case ADDRESS_HOME_STATE:
           group = GROUP_ADDRESS_STATE;
           break;
         case ADDRESS_HOME_ZIP:
           group = GROUP_ADDRESS_ZIP;
           break;
         case ADDRESS_HOME_COUNTRY:
           group = GROUP_ADDRESS_COUNTRY;
           break;
         default:
-          NOTREACHED();
+          NOTREACHED() << field_type << " has no group assigned (ambiguous)";
           group = GROUP_AMBIGUOUS;
           break;
       }
       break;
 
     case EMAIL:
       group = GROUP_EMAIL;
       break;
 
     case PHONE_HOME:
@@ skipping 14 matching lines @@
         case CREDIT_CARD_TYPE:
           group = GROUP_CREDIT_CARD_TYPE;
           break;
         case CREDIT_CARD_EXP_MONTH:
         case CREDIT_CARD_EXP_2_DIGIT_YEAR:
         case CREDIT_CARD_EXP_4_DIGIT_YEAR:
         case CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR:
         case CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR:
           group = GROUP_CREDIT_CARD_DATE;
           break;
+        case CREDIT_CARD_VERIFICATION_CODE:
+          group = GROUP_CREDIT_CARD_VERIFICATION;
+          break;
         default:
-          NOTREACHED();
+          NOTREACHED() << field_type << " has no group assigned (ambiguous)";
           group = GROUP_AMBIGUOUS;
           break;
       }
       break;
 
     case PASSWORD_FIELD:
       group = GROUP_PASSWORD;
       break;
 
     case USERNAME_FIELD:
@@ skipping 684 matching lines @@
   else if (is_server_data_available_ && !is_local_data_available_)
     name += ".WithOnlyServerData";
   else if (!is_server_data_available_ && is_local_data_available_)
     name += ".WithOnlyLocalData";
   else
     name += ".WithBothServerAndLocalData";
   LogUMAHistogramEnumeration(name, event, NUM_FORM_EVENTS);
 }
 
 }  // namespace autofill