ios/chrome/browser/sync/ios_chrome_sync_client.h - Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/sync/ios_chrome_sync_client.h

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)

Patch Set: CR maxbogue #23 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/sync/ios_chrome_sync_client.h

diff --git a/ios/chrome/browser/sync/ios_chrome_sync_client.h b/ios/chrome/browser/sync/ios_chrome_sync_client.h

index 5b8a735b61945925814a658b281bf69dd13d1a22..de1cf5158cc6d93348584b2ff94ad5109f40a5d7 100644

--- a/ios/chrome/browser/sync/ios_chrome_sync_client.h

+++ b/ios/chrome/browser/sync/ios_chrome_sync_client.h

@@ -55,8 +55,7 @@ class IOSChromeSyncClient : public syncer::SyncClient {

base::WeakPtr<syncer::ModelTypeSyncBridge> GetSyncBridgeForModelType(

syncer::ModelType type) override;

scoped_refptr<syncer::ModelSafeWorker> CreateModelWorkerForGroup(

- syncer::ModelSafeGroup group,

- syncer::WorkerLoopDestructionObserver* observer) override;

+ syncer::ModelSafeGroup group) override;

syncer::SyncApiComponentFactory* GetSyncApiComponentFactory() override;

void SetSyncApiComponentFactoryForTesting(