Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Side by Side Diff: ios/chrome/browser/sync/ios_chrome_sync_client.h

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)
Patch Set: CR maxbogue #23 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync/tools/sync_client.cc ('k') | ios/chrome/browser/sync/ios_chrome_sync_client.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_SYNC_IOS_CHROME_SYNC_CLIENT_H__ 5 #ifndef IOS_CHROME_BROWSER_SYNC_IOS_CHROME_SYNC_CLIENT_H__
6 #define IOS_CHROME_BROWSER_SYNC_IOS_CHROME_SYNC_CLIENT_H__ 6 #define IOS_CHROME_BROWSER_SYNC_IOS_CHROME_SYNC_CLIENT_H__
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 autofill::PersonalDataManager* GetPersonalDataManager() override; 48 autofill::PersonalDataManager* GetPersonalDataManager() override;
49 invalidation::InvalidationService* GetInvalidationService() override; 49 invalidation::InvalidationService* GetInvalidationService() override;
50 BookmarkUndoService* GetBookmarkUndoServiceIfExists() override; 50 BookmarkUndoService* GetBookmarkUndoServiceIfExists() override;
51 scoped_refptr<syncer::ExtensionsActivity> GetExtensionsActivity() override; 51 scoped_refptr<syncer::ExtensionsActivity> GetExtensionsActivity() override;
52 sync_sessions::SyncSessionsClient* GetSyncSessionsClient() override; 52 sync_sessions::SyncSessionsClient* GetSyncSessionsClient() override;
53 base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType( 53 base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType(
54 syncer::ModelType type) override; 54 syncer::ModelType type) override;
55 base::WeakPtr<syncer::ModelTypeSyncBridge> GetSyncBridgeForModelType( 55 base::WeakPtr<syncer::ModelTypeSyncBridge> GetSyncBridgeForModelType(
56 syncer::ModelType type) override; 56 syncer::ModelType type) override;
57 scoped_refptr<syncer::ModelSafeWorker> CreateModelWorkerForGroup( 57 scoped_refptr<syncer::ModelSafeWorker> CreateModelWorkerForGroup(
58 syncer::ModelSafeGroup group, 58 syncer::ModelSafeGroup group) override;
59 syncer::WorkerLoopDestructionObserver* observer) override;
60 syncer::SyncApiComponentFactory* GetSyncApiComponentFactory() override; 59 syncer::SyncApiComponentFactory* GetSyncApiComponentFactory() override;
61 60
62 void SetSyncApiComponentFactoryForTesting( 61 void SetSyncApiComponentFactoryForTesting(
63 std::unique_ptr<syncer::SyncApiComponentFactory> component_factory); 62 std::unique_ptr<syncer::SyncApiComponentFactory> component_factory);
64 63
65 // Iterates over browser states and returns any trackers that can be found. 64 // Iterates over browser states and returns any trackers that can be found.
66 static void GetDeviceInfoTrackers( 65 static void GetDeviceInfoTrackers(
67 std::vector<const syncer::DeviceInfoTracker*>* trackers); 66 std::vector<const syncer::DeviceInfoTracker*>* trackers);
68 67
69 private: 68 private:
(...skipping 10 matching lines...) Expand all
80 std::unique_ptr<sync_sessions::SyncSessionsClient> sync_sessions_client_; 79 std::unique_ptr<sync_sessions::SyncSessionsClient> sync_sessions_client_;
81 80
82 const scoped_refptr<syncer::ExtensionsActivity> dummy_extensions_activity_; 81 const scoped_refptr<syncer::ExtensionsActivity> dummy_extensions_activity_;
83 82
84 base::WeakPtrFactory<IOSChromeSyncClient> weak_ptr_factory_; 83 base::WeakPtrFactory<IOSChromeSyncClient> weak_ptr_factory_;
85 84
86 DISALLOW_COPY_AND_ASSIGN(IOSChromeSyncClient); 85 DISALLOW_COPY_AND_ASSIGN(IOSChromeSyncClient);
87 }; 86 };
88 87
89 #endif // IOS_CHROME_BROWSER_SYNC_IOS_CHROME_SYNC_CLIENT_H__ 88 #endif // IOS_CHROME_BROWSER_SYNC_IOS_CHROME_SYNC_CLIENT_H__
OLDNEW
« no previous file with comments | « components/sync/tools/sync_client.cc ('k') | ios/chrome/browser/sync/ios_chrome_sync_client.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698