components/sync/driver/sync_client.h - Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/sync_client.h

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)

Patch Set: CR maxbogue #22 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/sync_client.h

diff --git a/components/sync/driver/sync_client.h b/components/sync/driver/sync_client.h

index f819bc23584ec2ed5d7fafbd3e0af024d89fef76..b1a7ae399d1aee4f36af0854ea62e0a512f935d8 100644

--- a/components/sync/driver/sync_client.h

+++ b/components/sync/driver/sync_client.h

@@ -104,8 +104,7 @@ class SyncClient {

// cannot be created.

// TODO(maxbogue): Move this inside SyncApiComponentFactory.

virtual scoped_refptr<ModelSafeWorker> CreateModelWorkerForGroup(

- ModelSafeGroup group,

- WorkerLoopDestructionObserver* observer) = 0;

+ ModelSafeGroup group) = 0;

// Returns the current SyncApiComponentFactory instance.

virtual SyncApiComponentFactory* GetSyncApiComponentFactory() = 0;