components/sync/driver/glue/ui_model_worker_unittest.cc - Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/glue/ui_model_worker_unittest.cc

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)

Patch Set: CR maxbogue #22 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/glue/ui_model_worker_unittest.cc

diff --git a/components/sync/driver/glue/ui_model_worker_unittest.cc b/components/sync/driver/glue/ui_model_worker_unittest.cc

index 2c83554c25b8938b46499edbfca9a60610d8a873..d091f317a5c60f2896c0a05ec84abbea9095a730 100644

--- a/components/sync/driver/glue/ui_model_worker_unittest.cc

+++ b/components/sync/driver/glue/ui_model_worker_unittest.cc

@@ -36,7 +36,7 @@ class SyncUIModelWorkerTest : public testing::Test {

public:

SyncUIModelWorkerTest() : sync_thread_("SyncThreadForTest") {

sync_thread_.Start();

- worker_ = new UIModelWorker(base::ThreadTaskRunnerHandle::Get(), nullptr);

+ worker_ = new UIModelWorker(base::ThreadTaskRunnerHandle::Get());

}

void PostWorkToSyncThread(WorkCallback work) {