Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2471173002: gpu_test: enable Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing (Closed)

Created:
4 years, 1 month ago by dshwang
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu_test: enable Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing https://codereview.chromium.org/2454153002 requests r4 new revision, and cloud is ready. Check https://console.cloud.google.com/storage/browser/chromium-gpu-archive/reference-images/?pli=1&prefix=Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/a6a0a961f10a944f931d0e18dcdf951fedf44b07 Cr-Commit-Position: refs/heads/master@{#429666}

Patch Set 1 #

Patch Set 2 : rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
dshwang
Ken, could you review this follow-up CL of https://codereview.chromium.org/2454153002 ?
4 years, 1 month ago (2016-11-02 16:28:53 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
4 years, 1 month ago (2016-11-02 20:16:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471173002/1
4 years, 1 month ago (2016-11-02 22:42:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/295549)
4 years, 1 month ago (2016-11-03 00:48:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471173002/20001
4 years, 1 month ago (2016-11-03 17:27:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 19:16:02 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a6a0a961f10a944f931d0e18dcdf951fedf44b07 Cr-Commit-Position: refs/heads/master@{#429666}
4 years, 1 month ago (2016-11-03 19:20:28 UTC) #18
Jamie Madill
4 years, 1 month ago (2016-11-04 19:40:05 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2479923002/ by jmadill@chromium.org.

The reason for reverting is: Failing on Mac Retina GPU FYI bot:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release...

.

Powered by Google App Engine
This is Rietveld 408576698