mac: Offscreen Canvas sets texture wrap to CLAMP_TO_EDGE explicitly

mac: Offscreen Canvas sets texture wrap to CLAMP_TO_EDGE explicitly

OpenGL ES 2.0 defines the default texture wrap is CLAMP_TO_EDGE.
However, some MacOSX drivers don't respect it. Offscreen Canvas
doesn't explicitly define texture wrap, and some MacOSX handle it
as GL_CLAMP_TO_BORDER.

As a result, the edge of the texture of Offscreen Canvas is slightly
mixed with the border color, which is black.

This CL fixes it.

TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release --test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
BUG=615325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/5cd34fe6b6331792a9501cb9e9024d4a6a9dea7f
Cr-Commit-Position: refs/heads/master@{#428505}

[inactive_dshwang_plz_cc_intel, 2016-10-27 16:09:22]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 16:10:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dshwang, 2016-10-27 18:05:21]

Description was changed from

==========
mac: fix

Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing

TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
BUG=
==========

to

==========
mac: fix

Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing

TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[inactive_dshwang_plz_cc_intel, 2016-10-27 18:05:31]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 18:06:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dshwang, 2016-10-27 18:12:59]

Description was changed from

==========
mac: fix

Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing

TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
mac: Offscreen Canvas sets texture wrap to CLAMP_TO_EDGE explicitly

OpenGL ES 2.0 defines the default texture wrap is CLAMP_TO_EDGE.
However, some MacOSX drivers don't respect it. Offscreen Canvas 
doesn't explicitly define texture wrap, and some MacOSX handle it
as GL_CLAMP_TO_BORDER.

As a result, the edge of the texture of Offscreen Canvas is slightly
mixed with the border color, which is black.

This CL fixes it.


TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
BUG=615325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[dshwang, 2016-10-27 18:13:40]

dongseong.hwang@intel.com changed reviewers:
+ junov@chromium.org
- dongseong.hwang@chromium.org

[dshwang, 2016-10-27 18:18:17]

dongseong.hwang@intel.com changed reviewers:
+ kbr@chromium.org

[dshwang, 2016-10-27 18:18:18]

Justin, could you review?
https://codereview.chromium.org/2418173002 revealed this hidden bug and cannot
be landed.


Ken, could you review content/test/gpu/gpu_tests/pixel_expectations.py?
I mark 2 tests to skipped, but I don't know how to rebase them. 
I think some googlers should rebase them in gs cloud, which external
contributors don't have permission. e.g.
gs://chromium-browser-gpu-tests/runs/fbc9027a5e6c067ca4a100d3ca38d7fe7e2703fa_mac_chromium_rel_ng_telemetry/gen/Pixel_CSS3DBlueBox_fbc9027a5e6c067ca4a100d3ca38d7fe7e2703fa.png

[dshwang, 2016-10-27 18:20:19]

Description was changed from

==========
mac: Offscreen Canvas sets texture wrap to CLAMP_TO_EDGE explicitly

OpenGL ES 2.0 defines the default texture wrap is CLAMP_TO_EDGE.
However, some MacOSX drivers don't respect it. Offscreen Canvas 
doesn't explicitly define texture wrap, and some MacOSX handle it
as GL_CLAMP_TO_BORDER.

As a result, the edge of the texture of Offscreen Canvas is slightly
mixed with the border color, which is black.

This CL fixes it.


TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
BUG=615325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
mac: Offscreen Canvas sets texture wrap to CLAMP_TO_EDGE explicitly

OpenGL ES 2.0 defines the default texture wrap is CLAMP_TO_EDGE.
However, some MacOSX drivers don't respect it. Offscreen Canvas 
doesn't explicitly define texture wrap, and some MacOSX handle it
as GL_CLAMP_TO_BORDER.

As a result, the edge of the texture of Offscreen Canvas is slightly
mixed with the border color, which is black.

This CL fixes it.

TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
BUG=615325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-27 21:15:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:15:31]

Dry run: Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[Ken Russell (switch to Gerrit), 2016-10-27 22:51:25]

https://codereview.chromium.org/2454153002/diff/20001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/pixel_expectations.py (right):

https://codereview.chromium.org/2454153002/diff/20001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/pixel_expectations.py:49: ['mac'], bug=615325)
There's no way to rebaseline these for just macOS so please mark them failing on
all platforms and update the revision numbers for these two tests in
src/content/test/gpu/gpu_tests/pixel_test_pages.py at the same time. Then wait a
while after this CL lands for the new baselines to be generated for all
platforms, and remove the failure expectations.

This is documented at:
https://www.chromium.org/developers/testing/gpu-testing#TOC-Updating-and-Addi...

[Ken Russell (switch to Gerrit), 2016-10-27 22:52:08]

+xidachen and xlai for any comments

[xidachen, 2016-10-28 01:17:40]

xidachen@chromium.org changed reviewers:
+ xidachen@chromium.org

[xidachen, 2016-10-28 01:17:41]

Thank you for fixing it. This change makes sense to me.

Please follow the document pointed out by Ken.

[inactive_dshwang_plz_cc_intel, 2016-10-28 08:43:02]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 08:43:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dshwang, 2016-10-28 08:43:34]

Justin, could you review?

https://codereview.chromium.org/2454153002/diff/20001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/pixel_expectations.py (right):

https://codereview.chromium.org/2454153002/diff/20001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/pixel_expectations.py:49: ['mac'], bug=615325)
On 2016/10/27 22:51:25, Ken Russell wrote:
> There's no way to rebaseline these for just macOS so please mark them failing
on
> all platforms and update the revision numbers for these two tests in
> src/content/test/gpu/gpu_tests/pixel_test_pages.py at the same time. Then wait
a
> while after this CL lands for the new baselines to be generated for all
> platforms, and remove the failure expectations.
> 
> This is documented at:
>
https://www.chromium.org/developers/testing/gpu-testing#TOC-Updating-and-Addi...

Thank you for explanation. Done.

[commit-bot: I haz the power, 2016-10-28 10:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 10:03:23]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[xidachen, 2016-10-28 12:04:30]

platform/graphics lgtm

[Justin Novosad, 2016-10-28 17:23:27]

lgtm

[dshwang, 2016-10-28 17:31:28]

On 2016/10/28 17:23:27, Justin Novosad wrote:
> lgtm

thank you for review!

kbr@, could you review content/test?

[Ken Russell (switch to Gerrit), 2016-10-28 18:07:44]

content/test/gpu lgtm

Please don't forget to follow up to this CL resetting the expectations to what
they were after the reference images are generated. Thanks.

[dshwang, 2016-10-28 18:39:36]

On 2016/10/28 18:07:44, Ken Russell wrote:
> content/test/gpu lgtm
> 
> Please don't forget to follow up to this CL resetting the expectations to what
> they were after the reference images are generated. Thanks.

Thank you for review. Ok, when v4 png appear in
https://console.cloud.google.com/storage/browser/chromium-gpu-archive/referen...
, I'll submit follow-up CL.

[dshwang, 2016-10-28 18:39:43]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2016-10-28 18:40:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 21:57:10]

Description was changed from

==========
mac: Offscreen Canvas sets texture wrap to CLAMP_TO_EDGE explicitly

OpenGL ES 2.0 defines the default texture wrap is CLAMP_TO_EDGE.
However, some MacOSX drivers don't respect it. Offscreen Canvas 
doesn't explicitly define texture wrap, and some MacOSX handle it
as GL_CLAMP_TO_BORDER.

As a result, the edge of the texture of Offscreen Canvas is slightly
mixed with the border color, which is black.

This CL fixes it.

TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
BUG=615325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
mac: Offscreen Canvas sets texture wrap to CLAMP_TO_EDGE explicitly

OpenGL ES 2.0 defines the default texture wrap is CLAMP_TO_EDGE.
However, some MacOSX drivers don't respect it. Offscreen Canvas 
doesn't explicitly define texture wrap, and some MacOSX handle it
as GL_CLAMP_TO_BORDER.

As a result, the edge of the texture of Offscreen Canvas is slightly
mixed with the border color, which is black.

This CL fixes it.

TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
BUG=615325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-28 21:57:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-28 22:01:04]

Description was changed from

==========
mac: Offscreen Canvas sets texture wrap to CLAMP_TO_EDGE explicitly

OpenGL ES 2.0 defines the default texture wrap is CLAMP_TO_EDGE.
However, some MacOSX drivers don't respect it. Offscreen Canvas 
doesn't explicitly define texture wrap, and some MacOSX handle it
as GL_CLAMP_TO_BORDER.

As a result, the edge of the texture of Offscreen Canvas is slightly
mixed with the border color, which is black.

This CL fixes it.

TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
BUG=615325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
mac: Offscreen Canvas sets texture wrap to CLAMP_TO_EDGE explicitly

OpenGL ES 2.0 defines the default texture wrap is CLAMP_TO_EDGE.
However, some MacOSX drivers don't respect it. Offscreen Canvas
doesn't explicitly define texture wrap, and some MacOSX handle it
as GL_CLAMP_TO_BORDER.

As a result, the edge of the texture of Offscreen Canvas is slightly
mixed with the border color, which is black.

This CL fixes it.

TEST=./content/test/gpu/run_gpu_integration_test.py pixel --browser=release
--test-filter OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
BUG=615325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/5cd34fe6b6331792a9501cb9e9024d4a6a9dea7f
Cr-Commit-Position: refs/heads/master@{#428505}
==========

[commit-bot: I haz the power, 2016-10-28 22:01:05]

Patchset 3 (id:??) landed as
https://crrev.com/5cd34fe6b6331792a9501cb9e9024d4a6a9dea7f
Cr-Commit-Position: refs/heads/master@{#428505}