[sensors] Close mock sensor stubs after test is finished

[sensors] Close mock sensor stubs after test is finished

Before this CL, mock sensor instance was reused by all tests. This CL adds
code that closes mocked sensor stubs after each test, so that on the Blink
side, SensorProxy will reset and release resources associated with the sensor.
This allows to write layout tests that simulate different behavior for the
sensor of the same type.

BUG=606766
Committed: https://crrev.com/f0948b6c3cec6e8764fef47ed299d5a77414a987
Cr-Commit-Position: refs/heads/master@{#429564}

[shalamov, 2016-11-02 13:17:48]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 13:17:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shalamov, 2016-11-02 13:21:18]

Description was changed from

==========
[sensors] Close mock sensor stubs after test is finished

Before this CL, mock sensor object was reused by all tests. This CL adds code
that closes mocked sensor stubs after each test, so that on the Blink side,
SensorProxy will reset and release resources associated with the sensor.
This allows to write layout tests that simulate different behavior for the
sensor of the same type.

BUG=606766
==========

to

==========
[sensors] Close mock sensor stubs after test is finished

Before this CL, mock sensor instance was reused by all tests. This CL adds 
code that closes mocked sensor stubs after each test, so that on the Blink
side, SensorProxy will reset and release resources associated with the sensor.
This allows to write layout tests that simulate different behavior for the
sensor of the same type.

BUG=606766
==========

[shalamov, 2016-11-02 13:21:18]

alexander.shalamov@intel.com changed reviewers:
+ mikhail.pozdnyakov@intel.com

[Mikhail, 2016-11-02 14:30:20]

lgtm

https://codereview.chromium.org/2471103002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/SensorProxy.h (right):

https://codereview.chromium.org/2471103002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/SensorProxy.h:85: String
sanitizedMessage = String(),
nit: pls add comment like "intentionally copied"

[commit-bot: I haz the power, 2016-11-02 14:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 14:39:32]

Dry run: This issue passed the CQ dry run.

[shalamov, 2016-11-02 14:53:59]

alexander.shalamov@intel.com changed reviewers:
+ haraken@chromium.org, timvolodine@chromium.org

[shalamov, 2016-11-02 14:54:00]

Please take a look.

[haraken, 2016-11-02 14:54:45]

LGTM

[shalamov, 2016-11-02 14:55:01]

https://codereview.chromium.org/2471103002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/SensorProxy.h (right):

https://codereview.chromium.org/2471103002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/SensorProxy.h:85: String
sanitizedMessage = String(),
On 2016/11/02 14:30:20, Mikhail wrote:
> nit: pls add comment like "intentionally copied"

Done.

[shalamov, 2016-11-03 07:57:28]

The CQ bit was checked by alexander.shalamov@intel.com

[shalamov, 2016-11-03 07:57:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikhail.pozdnyakov@intel.com
Link to the patchset: https://codereview.chromium.org/2471103002/#ps20001
(title: "Fix for comment from Mikhail")

[commit-bot: I haz the power, 2016-11-03 07:57:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 09:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 09:58:07]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[shalamov, 2016-11-03 13:46:45]

The CQ bit was checked by alexander.shalamov@intel.com

[commit-bot: I haz the power, 2016-11-03 13:47:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 13:50:58]

Description was changed from

==========
[sensors] Close mock sensor stubs after test is finished

Before this CL, mock sensor instance was reused by all tests. This CL adds 
code that closes mocked sensor stubs after each test, so that on the Blink
side, SensorProxy will reset and release resources associated with the sensor.
This allows to write layout tests that simulate different behavior for the
sensor of the same type.

BUG=606766
==========

to

==========
[sensors] Close mock sensor stubs after test is finished

Before this CL, mock sensor instance was reused by all tests. This CL adds 
code that closes mocked sensor stubs after each test, so that on the Blink
side, SensorProxy will reset and release resources associated with the sensor.
This allows to write layout tests that simulate different behavior for the
sensor of the same type.

BUG=606766
==========

[commit-bot: I haz the power, 2016-11-03 13:51:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 13:52:59]

Description was changed from

==========
[sensors] Close mock sensor stubs after test is finished

Before this CL, mock sensor instance was reused by all tests. This CL adds 
code that closes mocked sensor stubs after each test, so that on the Blink
side, SensorProxy will reset and release resources associated with the sensor.
This allows to write layout tests that simulate different behavior for the
sensor of the same type.

BUG=606766
==========

to

==========
[sensors] Close mock sensor stubs after test is finished

Before this CL, mock sensor instance was reused by all tests. This CL adds
code that closes mocked sensor stubs after each test, so that on the Blink
side, SensorProxy will reset and release resources associated with the sensor.
This allows to write layout tests that simulate different behavior for the
sensor of the same type.

BUG=606766

Committed: https://crrev.com/f0948b6c3cec6e8764fef47ed299d5a77414a987
Cr-Commit-Position: refs/heads/master@{#429564}
==========

[commit-bot: I haz the power, 2016-11-03 13:52:59]

Patchset 2 (id:??) landed as
https://crrev.com/f0948b6c3cec6e8764fef47ed299d5a77414a987
Cr-Commit-Position: refs/heads/master@{#429564}