Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorProxy.h

Issue 2471103002: [sensors] Close mock sensor stubs after test is finished (Closed)
Patch Set: Fix for comment from Mikhail Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/SensorProxy.h
diff --git a/third_party/WebKit/Source/modules/sensor/SensorProxy.h b/third_party/WebKit/Source/modules/sensor/SensorProxy.h
index 05c7c446b6f7d8a58ec576cd661ee3a616593ddb..942b0d7bad0a78bba1934509b17548160c6eb6cc 100644
--- a/third_party/WebKit/Source/modules/sensor/SensorProxy.h
+++ b/third_party/WebKit/Source/modules/sensor/SensorProxy.h
@@ -81,9 +81,10 @@ class SensorProxy final : public GarbageCollectedFinalized<SensorProxy>,
void SensorReadingChanged() override;
// Generic handler for a fatal error.
+ // String parameters are intentionally copied.
void handleSensorError(ExceptionCode = UnknownError,
- const String& sanitizedMessage = String(),
- const String& unsanitizedMessage = String());
+ String sanitizedMessage = String(),
+ String unsanitizedMessage = String());
void onSensorCreated(device::mojom::blink::SensorInitParamsPtr,
device::mojom::blink::SensorClientRequest);

Powered by Google App Engine
This is Rietveld 408576698