Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.
Issue 2471093002: Add flags for permission prompt experiments. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/about_flags.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 26566dac363832203729e6257d05b873a373ece9..84e4ee9f9f61bc2c9e362fd6caf6a31dd3be7967 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -15581,6 +15581,23 @@ read aloud to screenreader users to announce that a completion is available.">
</if>
<if expr="is_android">
+ <message name="IDS_FLAGS_MODAL_PERMISSION_PROMPTS_NAME" desc="Name for the flag to enable modal permission prompts on Android" translateable="false">
+ Modal Permission Prompts
+ </message>
+ <message name="IDS_FLAGS_MODAL_PERMISSION_PROMPTS_DESCRIPTION" desc="Description for the flag to enable modal permission prompts on Android." translateable="false">
+ Whether to use permission dialogs in place of permission infobars.
+ </message>
+ </if>
+ <if expr="not is_macosx">
+ <message name="IDS_FLAGS_PERMISSION_PROMPT_PERSISTENCE_TOGGLE_NAME" desc="Name for the flag to enable a persistence toggle in permission prompts" translateable="false">
benwells 2016/11/02 06:32:43 Nit: should this desc say "on Android" like all th
dominickn 2016/11/02 07:08:47 No, because this flag is on all non-OS X platforms
benwells 2016/11/02 07:14:05 Ah, OK, then the desc for the next one (....PERSIS
dominickn 2016/11/03 00:12:56 Done.
+ Modal Permission Prompts
benwells 2016/11/02 06:32:42 I think this string is incorrect.
dominickn 2016/11/02 07:08:47 Done.
+ </message>
+ <message name="IDS_FLAGS_PERMISSION_PROMPT_PERSISTENCE_TOGGLE_DESCRIPTION" desc="Description for the flag to enable a persistence toggle in permission prompts on Android" translateable="false">
+ Whether to display a persistence toggle in permission prompts.
+ </message>
+ </if>
+
+ <if expr="is_android">
<message name="IDS_FLAGS_NO_CREDIT_CARD_ABORT" desc="Title for the flag to enable the No Card Abort in Payment Request." translateable="false">
No Credit Card Abort
</message>
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/about_flags.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698