Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/browser/about_flags.cc

Issue 2471093002: Add flags for permission prompt experiments. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index a94a74bec9cd93622bbf31c3785cc15f5d5efc53..c7a5c71bf70ccb65c92951d65d61f97ac6d26400 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2066,6 +2066,19 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_ENABLE_DEFAULT_MEDIA_SESSION_DESCRIPTION, kOsDesktop,
MULTI_VALUE_TYPE(kEnableDefaultMediaSessionChoices)},
#endif // !OS_ANDROID
+#if defined(OS_ANDROID)
+ {"enable-modal-permission-prompts", IDS_FLAGS_MODAL_PERMISSION_PROMPTS_NAME,
benwells 2016/11/02 06:32:43 I think the name of the flag should just be "modal
dominickn 2016/11/02 07:08:47 Done.
+ IDS_FLAGS_MODAL_PERMISSION_PROMPTS_DESCRIPTION, kOsAndroid,
+ FEATURE_VALUE_TYPE(features::kModalPermissionPrompts)},
+#endif
+#if !defined(OS_MACOSX)
+ {"enable-permission-prompt-persistence-toggle",
+ IDS_FLAGS_PERMISSION_PROMPT_PERSISTENCE_TOGGLE_NAME,
+ IDS_FLAGS_PERMISSION_PROMPT_PERSISTENCE_TOGGLE_DESCRIPTION,
+ kOsWin | kOsCrOS | kOsLinux | kOsAndroid,
+ FEATURE_VALUE_TYPE(
+ features::kDisplayPersistenceToggleInPermissionPrompts)},
+#endif
#if defined(ENABLE_PRINT_PREVIEW)
{"print-scaling", IDS_FLAGS_PRINT_SCALING_NAME,
IDS_FLAGS_PRINT_SCALING_DESCRIPTION, kOsDesktop,

Powered by Google App Engine
This is Rietveld 408576698