Add flags for permission prompt experiments.

Add flags for permission prompt experiments.

This CL adds entries to chrome://flags to explicitly enable:
    a) modal permission prompts on Android; and
    b) the persistence toggle in permission prompts on Windows,
       ChromeOS, Linux, and Android

BUG=658125
Committed: https://crrev.com/b2df0eda3699122aa2f3fea7a76c261f91d274b2
Cr-Commit-Position: refs/heads/master@{#429511}

[dominickn, 2016-11-02 05:37:06]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 05:37:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-11-02 06:15:09]

dominickn@chromium.org changed reviewers:
+ benwells@chromium.org, isherman@chromium.org

[dominickn, 2016-11-02 06:15:10]

PTAL, thanks!

[benwells, 2016-11-02 06:32:43]

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:15592: +      <message
name="IDS_FLAGS_PERMISSION_PROMPT_PERSISTENCE_TOGGLE_NAME" desc="Name for the
flag to enable a persistence toggle in permission prompts"
translateable="false">
Nit: should this desc say "on Android" like all the others you're adding?

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:15593: +        Modal Permission Prompts
I think this string is incorrect.

https://codereview.chromium.org/2471093002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2471093002/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:2070: {"enable-modal-permission-prompts",
IDS_FLAGS_MODAL_PERMISSION_PROMPTS_NAME,
I think the name of the flag should just be "modal-permission-prompts" (and
similar for "permission-prompt-persistence-toggle").

[commit-bot: I haz the power, 2016-11-02 06:33:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 06:33:19]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-02 07:08:39]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2016-11-02 07:08:47]

Thanks! That was sloppy.

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:15592: +      <message
name="IDS_FLAGS_PERMISSION_PROMPT_PERSISTENCE_TOGGLE_NAME" desc="Name for the
flag to enable a persistence toggle in permission prompts"
translateable="false">
On 2016/11/02 06:32:43, benwells (slow) wrote:
> Nit: should this desc say "on Android" like all the others you're adding?

No, because this flag is on all non-OS X platforms right now.

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:15593: +        Modal Permission Prompts
On 2016/11/02 06:32:42, benwells (slow) wrote:
> I think this string is incorrect.

Done.

https://codereview.chromium.org/2471093002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2471093002/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:2070: {"enable-modal-permission-prompts",
IDS_FLAGS_MODAL_PERMISSION_PROMPTS_NAME,
On 2016/11/02 06:32:43, benwells (slow) wrote:
> I think the name of the flag should just be "modal-permission-prompts" (and
> similar for "permission-prompt-persistence-toggle").

Done.

[commit-bot: I haz the power, 2016-11-02 07:08:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benwells, 2016-11-02 07:14:05]

lgtm with one thing fixed.

Thanks for being sloppy, it makes me feel less bad taking three patch sets to
get something similar passing the try bots.

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:15592: +      <message
name="IDS_FLAGS_PERMISSION_PROMPT_PERSISTENCE_TOGGLE_NAME" desc="Name for the
flag to enable a persistence toggle in permission prompts"
translateable="false">
On 2016/11/02 07:08:47, dominickn wrote:
> On 2016/11/02 06:32:43, benwells (slow) wrote:
> > Nit: should this desc say "on Android" like all the others you're adding?
> 
> No, because this flag is on all non-OS X platforms right now.

Ah, OK, then the desc for the next one (....PERSISTENCE....DESCRIPTION)
shouldn't say "on Android" to match...

[commit-bot: I haz the power, 2016-11-02 07:59:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 08:00:00]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-11-02 20:21:55]

histograms.xml lgtm

[dominickn, 2016-11-03 00:12:56]

Thanks!

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2471093002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:15592: +      <message
name="IDS_FLAGS_PERMISSION_PROMPT_PERSISTENCE_TOGGLE_NAME" desc="Name for the
flag to enable a persistence toggle in permission prompts"
translateable="false">
On 2016/11/02 07:14:05, benwells (slow) wrote:
> On 2016/11/02 07:08:47, dominickn wrote:
> > On 2016/11/02 06:32:43, benwells (slow) wrote:
> > > Nit: should this desc say "on Android" like all the others you're adding?
> > 
> > No, because this flag is on all non-OS X platforms right now.
> 
> Ah, OK, then the desc for the next one (....PERSISTENCE....DESCRIPTION)
> shouldn't say "on Android" to match...

Done.

[dominickn, 2016-11-03 00:12:57]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 00:13:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 01:44:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:44:49]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-03 01:48:47]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-11-03 01:48:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2471093002/#ps40001
(title: "Nit")

[commit-bot: I haz the power, 2016-11-03 01:49:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 02:00:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-03 02:03:05]

Description was changed from

==========
Add flags for permission prompt experiments.

This CL adds entries to chrome://flags to explicitly enable:
    a) modal permission prompts on Android; and
    b) the persistence toggle in permission prompts on Windows,
       ChromeOS, Linux, and Android

BUG=658125
==========

to

==========
Add flags for permission prompt experiments.

This CL adds entries to chrome://flags to explicitly enable:
    a) modal permission prompts on Android; and
    b) the persistence toggle in permission prompts on Windows,
       ChromeOS, Linux, and Android

BUG=658125

Committed: https://crrev.com/b2df0eda3699122aa2f3fea7a76c261f91d274b2
Cr-Commit-Position: refs/heads/master@{#429511}
==========

[commit-bot: I haz the power, 2016-11-03 02:03:06]

Patchset 3 (id:??) landed as
https://crrev.com/b2df0eda3699122aa2f3fea7a76c261f91d274b2
Cr-Commit-Position: refs/heads/master@{#429511}