headless: Add a browser manifest overlay

headless: Add a browser manifest overlay

Add a browser manifest overlay which permits exposing the necessary
services to the renderer.

BUG=546953
Committed: https://crrev.com/4723dd668c76115f026731b4af51aa38d1ce47dd
Cr-Commit-Position: refs/heads/master@{#429255}

[Sami, 2016-11-02 11:59:35]

Description was changed from

==========
headless: Add a browser manifest overlay

Add a browser manifest overlay which permits exposing the necessary
services to the renderer.

BUG=546953
==========

to

==========
headless: Add a browser manifest overlay

Add a browser manifest overlay which permits exposing the necessary
services to the renderer.

BUG=546953
==========

[Sami, 2016-11-02 11:59:35]

skyostil@chromium.org changed reviewers:
+ eseckler@chromium.org

[Eric Seckler, 2016-11-02 12:11:11]

lgtm :)

https://codereview.chromium.org/2471023003/diff/1/headless/lib/browser/headle...
File headless/lib/browser/headless_content_browser_client.cc (right):

https://codereview.chromium.org/2471023003/diff/1/headless/lib/browser/headle...
headless/lib/browser/headless_content_browser_client.cc:62: if (id == -1)
Will we be handling more than kBrowserServiceName? Otherwise, does it make sense
to change this to

if (name != content::kBrowserServiceName)
  return nullptr;

and get rid of "int id"?

https://codereview.chromium.org/2471023003/diff/1/headless/lib/browser/headle...
headless/lib/browser/headless_content_browser_client.cc:65:
ui::ResourceBundle::GetSharedInstance().GetRawDataResourceForScale(
nit: use GetRawDataResource() and get rid of SCALE_FACTOR_NONE arg?

[Sami, 2016-11-02 12:15:03]

Thanks!

https://codereview.chromium.org/2471023003/diff/1/headless/lib/browser/headle...
File headless/lib/browser/headless_content_browser_client.cc (right):

https://codereview.chromium.org/2471023003/diff/1/headless/lib/browser/headle...
headless/lib/browser/headless_content_browser_client.cc:62: if (id == -1)
On 2016/11/02 12:11:10, Eric Seckler wrote:
> Will we be handling more than kBrowserServiceName? Otherwise, does it make
sense
> to change this to
> 
> if (name != content::kBrowserServiceName)
>   return nullptr;
> 
> and get rid of "int id"?

Good point. I just blindly copied this from the WebView example which looks the
same. I agree -- let's rewrite it to be more general later and do the dumb and
simple thing now.

https://codereview.chromium.org/2471023003/diff/1/headless/lib/browser/headle...
headless/lib/browser/headless_content_browser_client.cc:65:
ui::ResourceBundle::GetSharedInstance().GetRawDataResourceForScale(
On 2016/11/02 12:11:10, Eric Seckler wrote:
> nit: use GetRawDataResource() and get rid of SCALE_FACTOR_NONE arg?

Good tip -- done.

[Sami, 2016-11-02 12:15:48]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-11-02 12:15:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
eseckler@chromium.org
Link to the patchset: https://codereview.chromium.org/2471023003/#ps20001
(title: "Review comments")

[commit-bot: I haz the power, 2016-11-02 12:15:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 12:24:47]

Description was changed from

==========
headless: Add a browser manifest overlay

Add a browser manifest overlay which permits exposing the necessary
services to the renderer.

BUG=546953
==========

to

==========
headless: Add a browser manifest overlay

Add a browser manifest overlay which permits exposing the necessary
services to the renderer.

BUG=546953
==========

[commit-bot: I haz the power, 2016-11-02 12:24:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-02 12:27:24]

Description was changed from

==========
headless: Add a browser manifest overlay

Add a browser manifest overlay which permits exposing the necessary
services to the renderer.

BUG=546953
==========

to

==========
headless: Add a browser manifest overlay

Add a browser manifest overlay which permits exposing the necessary
services to the renderer.

BUG=546953

Committed: https://crrev.com/4723dd668c76115f026731b4af51aa38d1ce47dd
Cr-Commit-Position: refs/heads/master@{#429255}
==========

[commit-bot: I haz the power, 2016-11-02 12:27:25]

Patchset 2 (id:??) landed as
https://crrev.com/4723dd668c76115f026731b4af51aa38d1ce47dd
Cr-Commit-Position: refs/heads/master@{#429255}