headless: Add a browser manifest overlay

headless/lib/browser/headless_content_browser_client.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "headless/lib/browser/headless_content_browser_client.h"
 
 #include <memory>
 
 #include "base/callback.h"
+#include "base/json/json_reader.h"
 #include "base/memory/ptr_util.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
+#include "content/public/common/service_names.h"
+#include "headless/grit/headless_lib_resources.h"
 #include "headless/lib/browser/headless_browser_context_impl.h"
 #include "headless/lib/browser/headless_browser_impl.h"
 #include "headless/lib/browser/headless_browser_main_parts.h"
 #include "headless/lib/browser/headless_devtools_manager_delegate.h"
+#include "ui/base/resource/resource_bundle.h"
 
 namespace headless {
 
 HeadlessContentBrowserClient::HeadlessContentBrowserClient(
     HeadlessBrowserImpl* browser)
     : browser_(browser) {}
 
 HeadlessContentBrowserClient::~HeadlessContentBrowserClient() {}
 
 content::BrowserMainParts* HeadlessContentBrowserClient::CreateBrowserMainParts(
@@ skipping 13 matching lines @@
       browser_context->options()->override_web_preferences_callback();
   if (callback)
     callback.Run(prefs);
 }
 
 content::DevToolsManagerDelegate*
 HeadlessContentBrowserClient::GetDevToolsManagerDelegate() {
   return new HeadlessDevToolsManagerDelegate(browser_->GetWeakPtr());
 }
 
+std::unique_ptr<base::Value>
+HeadlessContentBrowserClient::GetServiceManifestOverlay(
+    const std::string& name) {
+  int id = -1;
+  if (name == content::kBrowserServiceName)
+    id = IDR_HEADLESS_BROWSER_MANIFEST_OVERLAY;
+  if (id == -1)

[Eric Seckler, 2016/11/02 12:11:10]

Will we be handling more than kBrowserServiceName? Otherwise, does it make sense
to change this to

if (name != content::kBrowserServiceName)
  return nullptr;

and get rid of "int id"?

[Sami, 2016/11/02 12:15:03]

Good point. I just blindly copied this from the WebView example which looks the
same. I agree -- let's rewrite it to be more general later and do the dumb and
simple thing now.

+    return nullptr;
+  base::StringPiece manifest_contents =
+      ui::ResourceBundle::GetSharedInstance().GetRawDataResourceForScale(

[Eric Seckler, 2016/11/02 12:11:10]

nit: use GetRawDataResource() and get rid of SCALE_FACTOR_NONE arg?

[Sami, 2016/11/02 12:15:03]

Good tip -- done.

+          id, ui::ScaleFactor::SCALE_FACTOR_NONE);
+  return base::JSONReader::Read(manifest_contents);
+}
+
 }  // namespace headless