Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3153)

Unified Diff: appengine/swarming/ui/res/imp/taskpage/task-page-data.html

Issue 2470973003: give user notification if bot or task not found (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/ui/res/imp/taskpage/task-page-data.html
diff --git a/appengine/swarming/ui/res/imp/taskpage/task-page-data.html b/appengine/swarming/ui/res/imp/taskpage/task-page-data.html
index 98746586ae5754d3f5c76ba2598736180b4b4efb..497052337e35b95a7f46bb1450377fb609a491d9 100644
--- a/appengine/swarming/ui/res/imp/taskpage/task-page-data.html
+++ b/appengine/swarming/ui/res/imp/taskpage/task-page-data.html
@@ -91,6 +91,11 @@
computed: "_parseStdout(_stdout)",
notify: true,
},
+ task_exists: {
+ type: Boolean,
+ value: true,
+ notify: true,
+ },
// private
_busy1: {
@@ -132,8 +137,13 @@
var baseUrl = "/api/swarming/v1/task/" + this.task_id;
lastRequest = this.async(function(){
lastRequest = undefined;
- this._getJsonAsync("_request", baseUrl + "/request",
+ var p = this._getJsonAsync("_request", baseUrl + "/request",
"_busy1", this.auth_headers);
+ p.then(function(){
+ this.set("task_exists", true);
+ }.bind(this)).catch(function(){
+ this.set("task_exists", false);
nodir 2016/11/02 18:46:29 same here
kjlubick 2016/11/03 15:48:35 Done.
+ }.bind(this));
this._getJsonAsync("_result",
baseUrl + "/result?include_performance_stats=true",
"_busy2", this.auth_headers);

Powered by Google App Engine
This is Rietveld 408576698