Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2361)

Unified Diff: appengine/swarming/ui/res/imp/common/common-behavior.html

Issue 2470973003: give user notification if bot or task not found (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/ui/res/imp/common/common-behavior.html
diff --git a/appengine/swarming/ui/res/imp/common/common-behavior.html b/appengine/swarming/ui/res/imp/common/common-behavior.html
index 68712d51a2f3dc7b1db7eaa7f64c166f56602a4b..689eff7b3dc8a17c706751b92943ccc0da6413ea 100644
--- a/appengine/swarming/ui/res/imp/common/common-behavior.html
+++ b/appengine/swarming/ui/res/imp/common/common-behavior.html
@@ -77,7 +77,7 @@
if (params) {
url = url + "?" + sk.query.fromParamSet(params);
}
- sk.request("GET", url, "", headers).then(JSON.parse).then(function(json){
+ return sk.request("GET", url, "", headers).then(JSON.parse).then(function(json){
if (this._jsonAsync[bindTo] !== now) {
console.log("ignoring result because a second request happened.");
this.set(busy, false);
@@ -95,6 +95,7 @@
}
this.set(bindTo, false);
this.set(busy, false);
+ return Promise.reject(reason);
nodir 2016/11/02 18:46:29 What is reason? Can a caller check HTTP status cod
kjlubick 2016/11/03 15:48:35 reason is (after https://skia-review.googlesource.
nodir 2016/11/03 18:34:16 i think it should a part of the comment. The fact
kjlubick 2016/11/03 19:23:54 Done.
}.bind(this));
},

Powered by Google App Engine
This is Rietveld 408576698