chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java - Issue 2470913009: 📰 Refactor SuggestionsSection change detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2470913009: 📰 Refactor SuggestionsSection change detection (Closed)

Patch Set: address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/OptionalLeaf.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

index a7489450611910704b0163cbc878d994b381a75d..43aecbd482f885bd16219c969e1188d22d899c5d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

@@ -570,7 +570,7 @@ public ViewHolder getDismissSibling(ViewHolder viewHolder) {

}

private boolean hasAllBeenDismissed() {

- return mSections.isEmpty() && !mSigninPromo.isShown();

+ return mSections.isEmpty() && !mSigninPromo.isVisible();

}

private boolean canLoadSuggestions(@CategoryInt int category, @CategoryStatusEnum int status) {