Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2470913009: 📰 Refactor SuggestionsSection change detection (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
index af89ba7a156b66bb1fd61e66759424ed9c74c4b9..d2d0b7552ab689314bfbb305d875e1ec81c9d245 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
@@ -20,9 +20,9 @@
private boolean mImpressionTracked = false;
- public ActionItem(SuggestionsCategoryInfo categoryInfo, SuggestionsSection section) {
+ public ActionItem(SuggestionsSection section) {
super(section);
- mCategoryInfo = categoryInfo;
+ mCategoryInfo = section.getCategoryInfo();
mParentSection = section;
}
@@ -37,11 +37,6 @@ protected void onBindViewHolder(NewTabPageViewHolder holder) {
((ViewHolder) holder).onBindViewHolder(this);
}
- @Override
- public boolean isShown() {
- return mCategoryInfo.hasMoreButton(mParentSection.hasSuggestions());
- }
-
private int getPosition() {
// TODO(dgn): looks dodgy. Confirm that's what we want.
return mParentSection.getSuggestionsCount();
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698