components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java - Issue 2470903002: Add default implementation of experimental methods

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java

Issue 2470903002: Add default implementation of experimental methods (Closed)

Patch Set: Addressed Paul's comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java ('K') | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java b/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java

index eab6c84ae3f66587e3ffd9a1a903cc25cabcdaf2..b979ab79aa74aba1a3ef574d352e72189e535972 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java

@@ -8,12 +8,11 @@ import static android.os.Process.THREAD_PRIORITY_BACKGROUND;

import static android.os.Process.THREAD_PRIORITY_MORE_FAVORABLE;

import org.chromium.net.BidirectionalStream;

-import org.chromium.net.EffectiveConnectionType;

import org.chromium.net.ExperimentalBidirectionalStream;

+import org.chromium.net.ExperimentalCronetEngine;

pauljensen 2016/11/09 19:55:16 can we remove this and instead just import static

kapishnikov 2016/11/09 20:17:19 Removed

import org.chromium.net.NetworkQualityRttListener;

import org.chromium.net.NetworkQualityThroughputListener;

import org.chromium.net.RequestFinishedInfo;

-import org.chromium.net.RttThroughputValues;

import org.chromium.net.UrlRequest;

import java.io.IOException;

@@ -120,22 +119,22 @@ public final class JavaCronetEngine extends CronetEngineBase {

@Override

public int getEffectiveConnectionType() {

- return EffectiveConnectionType.TYPE_UNKNOWN;

+ return EFFECTIVE_CONNECTION_TYPE_UNKNOWN;

pauljensen 2016/11/09 19:55:16 wait, how can it find this member? it's not impor

kapishnikov 2016/11/09 20:17:19 It can find it because it is declared in the super

}

@Override

public int getHttpRttMs() {

- return RttThroughputValues.INVALID_RTT_THROUGHPUT;

+ return ExperimentalCronetEngine.CONNECTION_METRIC_UNKNOWN;

}

@Override

public int getTransportRttMs() {

- return RttThroughputValues.INVALID_RTT_THROUGHPUT;

+ return ExperimentalCronetEngine.CONNECTION_METRIC_UNKNOWN;

}

@Override

public int getDownstreamThroughputKbps() {

- return RttThroughputValues.INVALID_RTT_THROUGHPUT;

+ return ExperimentalCronetEngine.CONNECTION_METRIC_UNKNOWN;

}

@Override