components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java - Issue 2470903002: Add default implementation of experimental methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 2470903002: Add default implementation of experimental methods (Closed)

Patch Set: Addressed Paul's comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java ('K') | « components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

index 55061dae4525754754eb6e67654e39bf2c7ed3f3..de389c870ef223f598e5b3b57eb81b9b701d858d 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

@@ -346,7 +346,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {

// Verify that the HTTP RTT, transport RTT and downstream throughput

// estimates are available.

if (testFramework.mCronetEngine.getEffectiveConnectionType()

- != EffectiveConnectionType.TYPE_OFFLINE) {

+ != ExperimentalCronetEngine.EFFECTIVE_CONNECTION_TYPE_OFFLINE) {

assertTrue(testFramework.mCronetEngine.getHttpRttMs() > 0);

assertTrue(testFramework.mCronetEngine.getTransportRttMs() > 0);

assertTrue(testFramework.mCronetEngine.getDownstreamThroughputKbps() > 0);