content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java - Issue 2470713002: [WIP Approach 1] Straighten up input method reactivation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java

Issue 2470713002: [WIP Approach 1] Straighten up input method reactivation

Patch Set: fix some tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java

index d63f7ed61eda87aa84d59065efd8355622218a75..65bc0c80eabc3bfa80ab5e0648f0de2e0c9a8192 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java

@@ -20,7 +20,7 @@ import org.chromium.base.VisibleForTesting;

// See crbug.com/588547 for details.

public class ThreadedInputConnectionFactory implements ChromiumBaseInputConnection.Factory {

private static final String TAG = "cr_Ime";

- private static final boolean DEBUG_LOGS = false;

+ private static final boolean DEBUG_LOGS = true;

// Most of the time we do not need to retry. But if we have lost window focus while triggering

// delayed creation, then there is a chance that detection may fail in the following scenario: