content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java - Issue 2470713002: [WIP Approach 1] Straighten up input method reactivation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

Issue 2470713002: [WIP Approach 1] Straighten up input method reactivation

Patch Set: fix some tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

index f7fb2f01ea37b58cdbca61ce507367a1c9900246..6ca8e2e0200f07597ac5fdfc5259ba6cb724d8a3 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

@@ -40,7 +40,7 @@ import java.util.concurrent.LinkedBlockingQueue;

public class ThreadedInputConnection extends BaseInputConnection

implements ChromiumBaseInputConnection {

private static final String TAG = "cr_Ime";

- private static final boolean DEBUG_LOGS = false;

+ private static final boolean DEBUG_LOGS = true;

private static final TextInputState UNBLOCKER = new TextInputState(

"", new Range(0, 0), new Range(-1, -1), false, false /* notFromIme */, false) {

@@ -166,7 +166,9 @@ public class ThreadedInputConnection extends BaseInputConnection

* @see ChromiumBaseInputConnection#onRestartInputOnUiThread()

@Override

- public void onRestartInputOnUiThread() {}

+ public void onRestartInputOnUiThread() {

+ if (DEBUG_LOGS) Log.d(TAG, "onRestartInputOnUiThread");

+ }

/**

* @see ChromiumBaseInputConnection#sendKeyEventOnUiThread(KeyEvent)