Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2470593002: [Devtools] New network canvas timeline now properly shows initiators (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] New network canvas timeline now properly shows initiators This patch restores the ability to show initiator chains in new network canvas timeline experiment. R=dgozman BUG=653738 Committed: https://crrev.com/a7311d598597d52745fd65a3f3ebd4c34b852521 Cr-Commit-Position: refs/heads/master@{#428944}

Patch Set 1 : changes #

Total comments: 2

Patch Set 2 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -37 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 3 chunks +13 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 1 4 chunks +33 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js View 1 2 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
allada
PTL
4 years, 1 month ago (2016-10-31 23:27:41 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2470593002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right): https://codereview.chromium.org/2470593002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js#newcode1176 third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:1176: * @return {!{initiators: !Set<!WebInspector.NetworkRequest>, initiated: !Set<!WebInspector.NetworkRequest>}} Let's typedef ...
4 years, 1 month ago (2016-11-01 01:31:15 UTC) #7
allada
done https://codereview.chromium.org/2470593002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right): https://codereview.chromium.org/2470593002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js#newcode1176 third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:1176: * @return {!{initiators: !Set<!WebInspector.NetworkRequest>, initiated: !Set<!WebInspector.NetworkRequest>}} On 2016/11/01 ...
4 years, 1 month ago (2016-11-01 01:37:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470593002/60001
4 years, 1 month ago (2016-11-01 01:38:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/171654)
4 years, 1 month ago (2016-11-01 02:54:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470593002/60001
4 years, 1 month ago (2016-11-01 04:56:36 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 1 month ago (2016-11-01 06:11:42 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 06:15:15 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7311d598597d52745fd65a3f3ebd4c34b852521
Cr-Commit-Position: refs/heads/master@{#428944}

Powered by Google App Engine
This is Rietveld 408576698