Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2470593002: [Devtools] New network canvas timeline now properly shows initiators (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 88a6af5f5e541267c0753f132bc4bd7ca1f0f824..8ef01cc642d95956370256dc522d11909ddaf3dc 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -464,8 +464,8 @@ WebInspector.NetworkLogViewColumns.prototype = {
this._timelineColumn.element.addEventListener("mousewheel", this._onMouseWheel.bind(this, false), { passive: true });
this._dataGridScroller.addEventListener("mousewheel",this._onMouseWheel.bind(this, true), true);
- this._timelineColumn.element.addEventListener("mousemove", event => this._networkLogView.setHoveredRequest(this._timelineColumn.getRequestFromPoint(event.offsetX, event.offsetY + event.target.offsetTop)), true);
- this._timelineColumn.element.addEventListener("mouseleave", this._networkLogView.setHoveredRequest.bind(this._networkLogView, null), true);
+ this._timelineColumn.element.addEventListener("mousemove", event => this._networkLogView.setHoveredRequest(this._timelineColumn.getRequestFromPoint(event.offsetX, event.offsetY + event.target.offsetTop), event.shiftKey), true);
+ this._timelineColumn.element.addEventListener("mouseleave", this._networkLogView.setHoveredRequest.bind(this._networkLogView, null, false), true);
this._timelineScroller = this._timelineColumn.contentElement.createChild("div", "network-timeline-v-scroll");
this._timelineScroller.addEventListener("scroll", this._syncScrollers.bind(this), { passive: true });
@@ -496,7 +496,7 @@ WebInspector.NetworkLogViewColumns.prototype = {
event.consume(true);
this._activeScroller.scrollTop -= event.wheelDeltaY;
this._syncScrollers();
- this._networkLogView.setHoveredRequest(this._timelineColumn.getRequestFromPoint(event.offsetX, event.offsetY));
+ this._networkLogView.setHoveredRequest(this._timelineColumn.getRequestFromPoint(event.offsetX, event.offsetY), event.shiftKey);
},
_syncScrollers: function()
@@ -538,11 +538,12 @@ WebInspector.NetworkLogViewColumns.prototype = {
/**
* @param {?WebInspector.NetworkRequest} request
+ * @param {boolean} highlightInitiatorChain
*/
- setHoveredRequest: function(request)
+ setHoveredRequest: function(request, highlightInitiatorChain)
{
if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
- this._timelineColumn.setHoveredRequest(request);
+ this._timelineColumn.setHoveredRequest(request, highlightInitiatorChain);
},
_createTimelineHeader: function()

Powered by Google App Engine
This is Rietveld 408576698