preserve color space when copy_nv12_textures_ is true

preserve color space when copy_nv12_textures_ is true

This should make color management work on most nvidia cards (With Win8 and later.)

BUG=576411, 655417
Committed: https://crrev.com/4c2b05e8f0675b31ec399fca5726bd3d4c29a577
Cr-Commit-Position: refs/heads/master@{#429806}

[hubbe, 2016-11-03 23:24:31]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[hubbe, 2016-11-03 23:25:22]

hubbe@chromium.org changed reviewers:
+ sandersd@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:26:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sandersd (OOO until July 31), 2016-11-03 23:31:58]

lgtm

https://codereview.chromium.org/2470363003/diff/1/media/gpu/dxva_video_decode...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2470363003/diff/1/media/gpu/dxva_video_decode...
media/gpu/dxva_video_decode_accelerator_win.cc:1756: if (share_nv12_textures_ ||
copy_nv12_textures_) {
Would it be possible to have the color conversion step clear the color space,
instead of not setting it here?

[commit-bot: I haz the power, 2016-11-04 03:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 03:20:11]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[hubbe, 2016-11-04 03:49:31]

https://codereview.chromium.org/2470363003/diff/1/media/gpu/dxva_video_decode...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2470363003/diff/1/media/gpu/dxva_video_decode...
media/gpu/dxva_video_decode_accelerator_win.cc:1756: if (share_nv12_textures_ ||
copy_nv12_textures_) {
On 2016/11/03 23:31:58, sandersd wrote:
> Would it be possible to have the color conversion step clear the color space,
> instead of not setting it here?

Possible: Yes, Pretty: No

The copy happens on another thread, so modifications wouldn't be thread-safe. In
addition, the dx11 path doesn't have a natural place
to put the clear because the copy_nv12_texures_ test only happens in the setup
code, so we might as well do it here.

[hubbe, 2016-11-04 03:50:47]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2016-11-04 03:51:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:01:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-04 06:04:56]

Description was changed from

==========
preserve color space when copy_nv12_textures_ is true

This should make color management work on most nvidia cards (With Win8 and
later.)

BUG=576411,655417
==========

to

==========
preserve color space when copy_nv12_textures_ is true

This should make color management work on most nvidia cards (With Win8 and
later.)

BUG=576411,655417

Committed: https://crrev.com/4c2b05e8f0675b31ec399fca5726bd3d4c29a577
Cr-Commit-Position: refs/heads/master@{#429806}
==========

[commit-bot: I haz the power, 2016-11-04 06:04:58]

Patchset 1 (id:??) landed as
https://crrev.com/4c2b05e8f0675b31ec399fca5726bd3d4c29a577
Cr-Commit-Position: refs/heads/master@{#429806}

[sandersd (OOO until July 31), 2016-11-04 17:51:34]

https://codereview.chromium.org/2470363003/diff/1/media/gpu/dxva_video_decode...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2470363003/diff/1/media/gpu/dxva_video_decode...
media/gpu/dxva_video_decode_accelerator_win.cc:1756: if (share_nv12_textures_ ||
copy_nv12_textures_) {
On 2016/11/04 03:49:31, hubbe wrote:
> On 2016/11/03 23:31:58, sandersd wrote:
> > Would it be possible to have the color conversion step clear the color
space,
> > instead of not setting it here?
> 
> Possible: Yes, Pretty: No
> 
> The copy happens on another thread, so modifications wouldn't be thread-safe.
In
> addition, the dx11 path doesn't have a natural place
> to put the clear because the copy_nv12_texures_ test only happens in the setup
> code, so we might as well do it here.

This really needs a comment if it's not changing.