preserve color space when copy_nv12_textures_ is true

media/gpu/dxva_video_decode_accelerator_win.cc

Index: media/gpu/dxva_video_decode_accelerator_win.cc
diff --git a/media/gpu/dxva_video_decode_accelerator_win.cc b/media/gpu/dxva_video_decode_accelerator_win.cc
index 192591550518195664fd11fa687a510732cb7d22..4b7a32b0bfd3001735bfb3e869b765e50f80f444 100644
--- a/media/gpu/dxva_video_decode_accelerator_win.cc
+++ b/media/gpu/dxva_video_decode_accelerator_win.cc
@@ -1753,7 +1753,10 @@ void DXVAVideoDecodeAccelerator::ProcessPendingSamples() {
 
       pending_sample->picture_buffer_id = index->second->id();
       index->second->set_bound();
-      index->second->set_color_space(pending_sample->color_space);
+      if (share_nv12_textures_ || copy_nv12_textures_) {

[sandersd (OOO until July 31), 2016/11/03 23:31:58]

Would it be possible to have the color conversion step clear the color space,
instead of not setting it here?

[hubbe, 2016/11/04 03:49:31]

Possible: Yes, Pretty: No

The copy happens on another thread, so modifications wouldn't be thread-safe. In
addition, the dx11 path doesn't have a natural place
to put the clear because the copy_nv12_texures_ test only happens in the setup
code, so we might as well do it here.

[sandersd (OOO until July 31), 2016/11/04 17:51:34]

This really needs a comment if it's not changing.

+        index->second->set_color_space(pending_sample->color_space);
+      }
+
       if (share_nv12_textures_) {
         main_thread_task_runner_->PostTask(
             FROM_HERE,
@@ -2276,7 +2279,8 @@ void DXVAVideoDecodeAccelerator::CopySurfaceComplete(
   RETURN_AND_NOTIFY_ON_FAILURE(result, "Failed to complete copying surface",
                                PLATFORM_FAILURE, );
 
-  NotifyPictureReady(picture_buffer->id(), input_buffer_id, gfx::ColorSpace());
+  NotifyPictureReady(picture_buffer->id(), input_buffer_id,
+                     picture_buffer->color_space());
 
   {
     base::AutoLock lock(decoder_lock_);