chrome/common/extensions/permissions/chrome_permission_message_rules.cc - Issue 2470193002: Introduce networking.onc as an alias for networkingPrivate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

Issue 2470193002: Introduce networking.onc as an alias for networkingPrivate (Closed)

Patch Set: allow optional permission Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc ('k') | chrome/test/data/extensions/api_test/networking_private/alias/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

index 1f5011b573fb8dca594b268dc5c361ceb3ffb70f..ec09d431509bda14db27a2eb2b720e28583fd50d 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

+++ b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

@@ -520,6 +520,15 @@ ChromePermissionMessageRule::GetAllRules() {

// Network-related permissions.

{IDS_EXTENSION_PROMPT_WARNING_NETWORKING_PRIVATE,

+ {APIPermission::kNetworkingOnc},

+ // Adding networkingPrivate as an optional permission for this rule so

+ // the permission is removed from the available permission set when the

+ // next rule (for networkingPrivate permission) is considered - without

+ // this, IDS_EXTENSION_PROMPT_WARNING_NETWORK_PRIVATE would be duplicated

+ // for manifests that have both networking.onc and networkingPrivate

+ // permission.

+ {APIPermission::kNetworkingPrivate}},

+ {IDS_EXTENSION_PROMPT_WARNING_NETWORKING_PRIVATE,

{APIPermission::kNetworkingPrivate},

{}},

{IDS_EXTENSION_PROMPT_WARNING_NETWORKING_CONFIG,