Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

Issue 2470193002: Introduce networking.onc as an alias for networkingPrivate (Closed)
Patch Set: allow optional permission Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/permissions/chrome_permission_message_rules.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
index 6d22232e525d13549a9a90808878987ff067850d..ec9cdc3f109f4fffcc91ed4ade1168911a17a863 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
+++ b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
@@ -9,6 +9,7 @@
#include "base/callback.h"
#include "base/command_line.h"
#include "base/macros.h"
+#include "base/strings/stringprintf.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chromeos/login/helper.h"
#include "chrome/browser/chromeos/net/network_portal_detector_test_impl.h"
@@ -167,10 +168,11 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {
service_test_(nullptr),
device_test_(nullptr) {}
- bool RunNetworkingSubtest(const std::string& subtest) {
- return RunExtensionSubtest("networking_private/chromeos",
- "main.html?" + subtest,
- kFlagEnableFileAccess | kFlagLoadAsComponent);
+ bool RunNetworkingSubtest(const std::string& test) {
+ const std::string arg =
+ base::StringPrintf("{\"test\": \"%s\"}", test.c_str());
+ return RunPlatformAppTestWithArg("networking_private/chromeos",
+ arg.c_str());
}
void SetUpInProcessBrowserTestFixture() override {
@@ -713,4 +715,11 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, CellularSimPuk) {
EXPECT_TRUE(RunNetworkingSubtest("cellularSimPuk")) << message_;
}
+// Tests subset of networking API for the networking API alias - to verify that
+// using API methods and event does not cause access exceptions (due to
+// missing permissions).
+IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, Alias) {
+ EXPECT_TRUE(RunPlatformAppTest("networking_private/alias")) << message_;
+}
+
} // namespace
« no previous file with comments | « no previous file | chrome/common/extensions/permissions/chrome_permission_message_rules.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698