Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: extensions/common/permissions/extensions_api_permissions.cc

Issue 2470193002: Introduce networking.onc as an alias for networkingPrivate (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/extensions_api_permissions.cc
diff --git a/extensions/common/permissions/extensions_api_permissions.cc b/extensions/common/permissions/extensions_api_permissions.cc
index 3ff3a499179618c89ebf295e2cdde87b88bb06c1..f4724e9f16669fecfaf633046574141f4670096f 100644
--- a/extensions/common/permissions/extensions_api_permissions.cc
+++ b/extensions/common/permissions/extensions_api_permissions.cc
@@ -64,6 +64,8 @@ ExtensionsAPIPermissions::GetAllPermissions() const {
{APIPermission::kMetricsPrivate, "metricsPrivate",
APIPermissionInfo::kFlagCannotBeOptional},
{APIPermission::kNetworkingConfig, "networking.config"},
+ {APIPermission::kNetworkingOnc, "networking.onc",
+ APIPermissionInfo::kFlagCannotBeOptional},
Devlin 2016/12/13 15:54:01 Why not optional?
tbarzic 2016/12/13 17:40:02 because networkingPrivate is the same way.
Devlin 2016/12/13 17:44:28 It's up for debate whether or not that should be,
tbarzic 2016/12/13 17:52:29 OK, Done.
{APIPermission::kNetworkingPrivate, "networkingPrivate",
APIPermissionInfo::kFlagCannotBeOptional},
{APIPermission::kPower, "power"},

Powered by Google App Engine
This is Rietveld 408576698