Introduce networking.onc as an alias for networkingPrivate

extensions/common/permissions/extensions_api_permissions.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/permissions/extensions_api_permissions.h"
 
 #include <stddef.h>
 
 #include <vector>
 
@@ skipping 46 matching lines @@
        "externally_connectable.all_urls"},
       {APIPermission::kFullscreen, "app.window.fullscreen"},
       {APIPermission::kHid, "hid"},
       {APIPermission::kImeWindowEnabled, "app.window.ime"},
       {APIPermission::kOverrideEscFullscreen,
        "app.window.fullscreen.overrideEsc"},
       {APIPermission::kIdle, "idle"},
       {APIPermission::kMetricsPrivate, "metricsPrivate",
        APIPermissionInfo::kFlagCannotBeOptional},
       {APIPermission::kNetworkingConfig, "networking.config"},
+      {APIPermission::kNetworkingOnc, "networking.onc",
+       APIPermissionInfo::kFlagCannotBeOptional},

[Devlin, 2016/12/13 15:54:01]

Why not optional?

[tbarzic, 2016/12/13 17:40:02]

because networkingPrivate is the same way.

[Devlin, 2016/12/13 17:44:28]

It's up for debate whether or not that should be, but having an optional private
permission is significantly weirder since it's designed to be used by component
extensions and webui primarily.  If this is going to be public, I'd say it
should be optional.

[tbarzic, 2016/12/13 17:52:29]

OK, Done.

       {APIPermission::kNetworkingPrivate, "networkingPrivate",
        APIPermissionInfo::kFlagCannotBeOptional},
       {APIPermission::kPower, "power"},
       {APIPermission::kPrinterProvider, "printerProvider"},
       {APIPermission::kSerial, "serial"},
       {APIPermission::kSocket, "socket",
        APIPermissionInfo::kFlagCannotBeOptional,
        &CreateAPIPermission<SocketPermission>},
       {APIPermission::kStorage, "storage"},
       {APIPermission::kSystemCpu, "system.cpu"},
@@ skipping 26 matching lines @@
 
   std::vector<std::unique_ptr<APIPermissionInfo>> permissions;
 
   for (size_t i = 0; i < arraysize(permissions_to_register); ++i)
     permissions.push_back(
         base::WrapUnique(new APIPermissionInfo(permissions_to_register[i])));
   return permissions;
 }
 
 }  // namespace extensions