Remove dependency on SurfaceManager in FrameGenerator

Remove dependency on SurfaceManager in FrameGenerator

FrameGenerator lives in the window server and thus should not have direct
access to SurfaceManager. This CL moves FrameGenerator's accesses to surface
manager to DisplayCompositor which will be placed behind a mojo interface in
a subsequent CL.

This CL takes us a step closer to removing the need for GpuChannelHost in
mus-ws by decoupling mus-ws and the display compositor.

BUG=661278
Committed: https://crrev.com/0146e3cdbf9163f044d0fc300a61747f98268878
Cr-Commit-Position: refs/heads/master@{#429971}

[Fady Samuel, 2016-11-04 15:36:31]

fsamuel@chromium.org changed reviewers:
+ kylechar@chromium.org

[kylechar, 2016-11-04 15:53:51]

lgtm

https://codereview.chromium.org/2470143006/diff/1/services/ui/ws/window_tree.cc
File services/ui/ws/window_tree.cc (right):

https://codereview.chromium.org/2470143006/diff/1/services/ui/ws/window_tree....
services/ui/ws/window_tree.cc:1379: sequences.push_back(sequence.sequence);
Optional change:

std::vector<uint32_t> sequences({sequence.sequence});

[Fady Samuel, 2016-11-04 17:17:05]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2016-11-04 17:17:05]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2016-11-04 17:17:06]

+sky@ for OWNERS

https://codereview.chromium.org/2470143006/diff/1/services/ui/ws/window_tree.cc
File services/ui/ws/window_tree.cc (right):

https://codereview.chromium.org/2470143006/diff/1/services/ui/ws/window_tree....
services/ui/ws/window_tree.cc:1379: sequences.push_back(sequence.sequence);
On 2016/11/04 15:53:51, kylechar wrote:
> Optional change:
> 
> std::vector<uint32_t> sequences({sequence.sequence});

Done.

[Fady Samuel, 2016-11-04 17:17:06]

+sky@ for OWNERS

https://codereview.chromium.org/2470143006/diff/1/services/ui/ws/window_tree.cc
File services/ui/ws/window_tree.cc (right):

https://codereview.chromium.org/2470143006/diff/1/services/ui/ws/window_tree....
services/ui/ws/window_tree.cc:1379: sequences.push_back(sequence.sequence);
On 2016/11/04 15:53:51, kylechar wrote:
> Optional change:
> 
> std::vector<uint32_t> sequences({sequence.sequence});

Done.

[Fady Samuel, 2016-11-04 17:20:14]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 17:20:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-04 17:34:51]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 17:35:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-04 17:55:34]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 17:56:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-11-04 17:58:18]

LGTM

[commit-bot: I haz the power, 2016-11-04 19:05:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 19:05:59]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-11-04 19:07:15]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-04 19:07:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
kylechar@chromium.org
Link to the patchset: https://codereview.chromium.org/2470143006/#ps80001
(title: "Remove a couple of bad std::moves")

[commit-bot: I haz the power, 2016-11-04 19:08:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:16:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-04 19:18:49]

Description was changed from

==========
Remove dependency on SurfaceManager in FrameGenerator

FrameGenerator lives in the window server and thus should not have direct
access to SurfaceManager. This CL moves FrameGenerator's accesses to surface
manager to DisplayCompositor which will be placed behind a mojo interface in
a subsequent CL.

This CL takes us a step closer to removing the need for GpuChannelHost in
mus-ws by decoupling mus-ws and the display compositor.

BUG=661278
==========

to

==========
Remove dependency on SurfaceManager in FrameGenerator

FrameGenerator lives in the window server and thus should not have direct
access to SurfaceManager. This CL moves FrameGenerator's accesses to surface
manager to DisplayCompositor which will be placed behind a mojo interface in
a subsequent CL.

This CL takes us a step closer to removing the need for GpuChannelHost in
mus-ws by decoupling mus-ws and the display compositor.

BUG=661278

Committed: https://crrev.com/0146e3cdbf9163f044d0fc300a61747f98268878
Cr-Commit-Position: refs/heads/master@{#429971}
==========

[commit-bot: I haz the power, 2016-11-04 19:18:50]

Patchset 5 (id:??) landed as
https://crrev.com/0146e3cdbf9163f044d0fc300a61747f98268878
Cr-Commit-Position: refs/heads/master@{#429971}