Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: services/ui/ws/window_tree.cc

Issue 2470143006: Remove dependency on SurfaceManager in FrameGenerator (Closed)
Patch Set: Remove a couple of bad std::moves Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/ui/ws/test_utils.cc ('k') | services/ui/ws/window_tree_host_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/ws/window_tree.h" 5 #include "services/ui/ws/window_tree.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 1357 matching lines...) Expand 10 before | Expand all | Expand 10 after
1368 nullptr, std::move(compositor_frame_sink), 1368 nullptr, std::move(compositor_frame_sink),
1369 std::move(client)); 1369 std::move(client));
1370 } 1370 }
1371 1371
1372 void WindowTree::OnWindowSurfaceDetached(Id transport_window_id, 1372 void WindowTree::OnWindowSurfaceDetached(Id transport_window_id,
1373 const cc::SurfaceSequence& sequence) { 1373 const cc::SurfaceSequence& sequence) {
1374 ServerWindow* window = 1374 ServerWindow* window =
1375 GetWindowByClientId(ClientWindowId(transport_window_id)); 1375 GetWindowByClientId(ClientWindowId(transport_window_id));
1376 if (!window) 1376 if (!window)
1377 return; 1377 return;
1378 window_server_->GetDisplayCompositor()->ReturnSurfaceReference(sequence); 1378 std::vector<uint32_t> sequences({sequence.sequence});
1379 window_server_->GetDisplayCompositor()->ReturnSurfaceReferences(
1380 sequence.frame_sink_id, std::move(sequences));
1379 } 1381 }
1380 1382
1381 void WindowTree::SetWindowTextInputState(Id transport_window_id, 1383 void WindowTree::SetWindowTextInputState(Id transport_window_id,
1382 mojo::TextInputStatePtr state) { 1384 mojo::TextInputStatePtr state) {
1383 ServerWindow* window = 1385 ServerWindow* window =
1384 GetWindowByClientId(ClientWindowId(transport_window_id)); 1386 GetWindowByClientId(ClientWindowId(transport_window_id));
1385 bool success = window && access_policy_->CanSetWindowTextInputState(window); 1387 bool success = window && access_policy_->CanSetWindowTextInputState(window);
1386 if (success) 1388 if (success)
1387 window->SetTextInputState(state.To<ui::TextInputState>()); 1389 window->SetTextInputState(state.To<ui::TextInputState>());
1388 } 1390 }
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
1945 client()->OnCompleteDrop(client_window_id.id, event_flags, cursor_offset, 1947 client()->OnCompleteDrop(client_window_id.id, event_flags, cursor_offset,
1946 effect_bitmask, callback); 1948 effect_bitmask, callback);
1947 } 1949 }
1948 1950
1949 void WindowTree::PerformOnDragDropDone() { 1951 void WindowTree::PerformOnDragDropDone() {
1950 client()->OnDragDropDone(); 1952 client()->OnDragDropDone();
1951 } 1953 }
1952 1954
1953 } // namespace ws 1955 } // namespace ws
1954 } // namespace ui 1956 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/ws/test_utils.cc ('k') | services/ui/ws/window_tree_host_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698