Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 247013008: Add support for Float/Double types for JS Mojo bindings. (Closed)

Created:
6 years, 8 months ago by Tom Sepez
Modified:
6 years, 8 months ago
Reviewers:
mpcomplete, sky, Matt Perry
CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Add support for Float/Double types for JS Mojo bindings. This is now straightforward using the underlying DataView representation used by the Mojo JS bindings, given its support for these types. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266040

Patch Set 1 #

Patch Set 2 : Tidy. #

Total comments: 1

Patch Set 3 : Comment EchoArgs struct. #

Patch Set 4 : Rebase. #

Patch Set 5 : Git gymnastics. #

Patch Set 6 : M_PI not present on some of the windows platforms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -22 lines) Patch
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 2 3 4 5 4 chunks +25 lines, -0 lines 0 comments Download
M content/test/data/web_ui_test_mojo_bindings.mojom View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/public/js/bindings/codec.js View 7 chunks +43 lines, -18 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Tom Sepez
Sky, MP, please review. I figured I would put this up as long as I ...
6 years, 8 months ago (2014-04-23 22:29:52 UTC) #1
sky
LGTM (I only looked at content, I'm assuming Matt will look at the rest). https://codereview.chromium.org/247013008/diff/20001/content/test/data/web_ui_test_mojo_bindings.mojom ...
6 years, 8 months ago (2014-04-23 22:37:05 UTC) #2
Matt Perry
I have a similar CL that I merged with your codec changes from yesterday: https://codereview.chromium.org/250253002/ ...
6 years, 8 months ago (2014-04-23 22:37:08 UTC) #3
Tom Sepez
Ok, at which point I think I'm hands off this since I should have enough ...
6 years, 8 months ago (2014-04-23 22:48:57 UTC) #4
Matt Perry
On 2014/04/23 22:48:57, Tom Sepez wrote: > Ok, at which point I think I'm hands ...
6 years, 8 months ago (2014-04-23 22:53:55 UTC) #5
Tom Sepez
On 2014/04/23 22:37:05, sky wrote: > LGTM (I only looked at content, I'm assuming Matt ...
6 years, 8 months ago (2014-04-23 22:55:03 UTC) #6
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 8 months ago (2014-04-24 20:44:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/247013008/100001
6 years, 8 months ago (2014-04-24 21:16:27 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:27:32 UTC) #9
Message was sent while issue was closed.
Change committed as 266040

Powered by Google App Engine
This is Rietveld 408576698