Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: mojo/public/tools/bindings/generators/mojom_js_generator.py

Issue 247013008: Add support for Float/Double types for JS Mojo bindings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: M_PI not present on some of the windows platforms. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/js/bindings/codec.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/generators/mojom_js_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_js_generator.py b/mojo/public/tools/bindings/generators/mojom_js_generator.py
index 53672a26774e57aea0b433425c1d182fd4bee074..adc1b7ddd317e0b06e104dee9d9203883a33879f 100644
--- a/mojo/public/tools/bindings/generators/mojom_js_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_js_generator.py
@@ -98,7 +98,7 @@ _kind_to_javascript_decode_snippet = {
mojom.UINT16: "readUint16()",
mojom.INT32: "readInt32()",
mojom.UINT32: "readUint32()",
- mojom.FLOAT: "decodeFloat()",
+ mojom.FLOAT: "readFloat()",
mojom.HANDLE: "decodeHandle()",
mojom.DCPIPE: "decodeHandle()",
mojom.DPPIPE: "decodeHandle()",
@@ -106,7 +106,7 @@ _kind_to_javascript_decode_snippet = {
mojom.SHAREDBUFFER: "decodeHandle()",
mojom.INT64: "readInt64()",
mojom.UINT64: "readUint64()",
- mojom.DOUBLE: "decodeDouble()",
+ mojom.DOUBLE: "readDouble()",
mojom.STRING: "decodeStringPointer()",
}
@@ -132,7 +132,7 @@ _kind_to_javascript_encode_snippet = {
mojom.UINT16: "writeUint16(",
mojom.INT32: "writeInt32(",
mojom.UINT32: "writeUint32(",
- mojom.FLOAT: "encodeFloat(",
+ mojom.FLOAT: "writeFloat(",
mojom.HANDLE: "encodeHandle(",
mojom.DCPIPE: "encodeHandle(",
mojom.DPPIPE: "encodeHandle(",
@@ -140,7 +140,7 @@ _kind_to_javascript_encode_snippet = {
mojom.SHAREDBUFFER: "encodeHandle(",
mojom.INT64: "writeInt64(",
mojom.UINT64: "writeUint64(",
- mojom.DOUBLE: "encodeDouble(",
+ mojom.DOUBLE: "writeDouble(",
mojom.STRING: "encodeStringPointer(",
}
« no previous file with comments | « mojo/public/js/bindings/codec.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698