Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2469983003: Trybot test for finishComposingText keeping style (Closed)

Created:
4 years, 1 month ago by yabinh
Modified:
4 years ago
Reviewers:
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trybot test for finishComposingText keeping style BUG=620549

Patch Set 1 : Delete and cancel #

Total comments: 2

Patch Set 2 : Do nothing #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 1 chunk +0 lines, -1 line 1 comment Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
yabinh
https://codereview.chromium.org/2469983003/diff/1/third_party/WebKit/Source/core/editing/InputMethodController.cpp File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right): https://codereview.chromium.org/2469983003/diff/1/third_party/WebKit/Source/core/editing/InputMethodController.cpp#newcode227 third_party/WebKit/Source/core/editing/InputMethodController.cpp:227: if (!m_isDirty && composingText() == text) { Delete and ...
4 years, 1 month ago (2016-11-02 07:07:49 UTC) #5
yabinh
https://codereview.chromium.org/2469983003/diff/1/third_party/WebKit/Source/core/editing/InputMethodController.cpp File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right): https://codereview.chromium.org/2469983003/diff/1/third_party/WebKit/Source/core/editing/InputMethodController.cpp#newcode227 third_party/WebKit/Source/core/editing/InputMethodController.cpp:227: if (!m_isDirty && composingText() == text) { On 2016/11/02 ...
4 years, 1 month ago (2016-11-02 07:14:48 UTC) #6
yabinh
4 years, 1 month ago (2016-11-02 07:19:39 UTC) #7
https://codereview.chromium.org/2469983003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right):

https://codereview.chromium.org/2469983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:227: if
(!m_isDirty && composingText() == text) {
If we do nothing here, no event will be fired.

Powered by Google App Engine
This is Rietveld 408576698