Trybot test for finishComposingText keeping style

third_party/WebKit/Source/core/editing/InputMethodController.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 206 matching lines @@
   return insertTextAndMoveCaret(text, relativeCaretPosition);
 }
 
 bool InputMethodController::replaceComposition(const String& text) {
   if (!hasComposition())
     return false;
 
   // If the composition was set from existing text and didn't change, then
   // there's nothing to do here (and we should avoid doing anything as that
   // may clobber multi-node styled text).
   if (!m_isDirty && composingText() == text) {

[yabinh, 2016/11/02 07:07:49]

Delete and cancel. It will fire 2 "input.data:null" events.

[yabinh, 2016/11/02 07:14:48]

See the result of InputMethodControllerTest#CompositionInputEventData

+    TypingCommand::closeTyping(m_frame);
+    selectComposition();
+    TypingCommand::deleteSelection(*frame().document(), 0);
+
+    editor().lastEditCommand()->ensureComposition()->unapply();
+
     clear();
     return true;
   }
 
   // Select the text that will be deleted or replaced.
   selectComposition();
 
   if (frame().selection().isNone())
     return false;
 
@@ skipping 277 matching lines @@
   selectComposition();
 
   // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited. see http://crbug.com/590369 for more details.
   frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
   const PlainTextRange& selectedRange = createSelectionRangeForSetComposition(
       selectionStart, selectionEnd, text.length());
   // We shouldn't close typing in the middle of setComposition.
   setEditableSelectionOffsets(selectedRange, NotUserTriggered);
-  m_isDirty = true;
 }
 
 void InputMethodController::setComposition(
     const String& text,
     const Vector<CompositionUnderline>& underlines,
     int selectionStart,
     int selectionEnd) {
   Editor::RevealSelectionScope revealSelectionScope(&editor());
 
   // Updates styles before setting selection for composition to prevent
@@ skipping 618 matching lines @@
 
   return WebTextInputTypeNone;
 }
 
 DEFINE_TRACE(InputMethodController) {
   visitor->trace(m_frame);
   visitor->trace(m_compositionRange);
 }
 
 }  // namespace blink