Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: components/ntp_snippets/offline_pages/offline_page_proxy.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)
Patch Set: Touch ups. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/offline_page_proxy.cc
diff --git a/components/ntp_snippets/offline_pages/offline_page_proxy.cc b/components/ntp_snippets/offline_pages/offline_page_proxy.cc
index 81976ad82ab025b6341131d8c2673762e94cdf77..d041d8d73fa6ae091e8426f15dd48032758326f7 100644
--- a/components/ntp_snippets/offline_pages/offline_page_proxy.cc
+++ b/components/ntp_snippets/offline_pages/offline_page_proxy.cc
@@ -6,9 +6,11 @@
#include "base/bind.h"
-using offline_pages::MultipleOfflinePageItemResult;
using offline_pages::MultipleOfflinePageItemCallback;
+using offline_pages::MultipleOfflinePageItemResult;
+using offline_pages::OfflinePageItem;
using offline_pages::OfflinePageModel;
+using SavePageResult = offline_pages::SavePageResult;
namespace ntp_snippets {
@@ -41,7 +43,9 @@ void OfflinePageProxy::OfflinePageModelLoaded(OfflinePageModel* model) {
DCHECK_EQ(offline_page_model_, model);
}
-void OfflinePageProxy::OfflinePageModelChanged(OfflinePageModel* model) {
+void OfflinePageProxy::OfflinePageAdded(OfflinePageModel* model,
fgorski 2016/11/02 15:51:06 Please ping the owners of this class, as they may
dewittj 2016/11/02 16:34:37 That's the plan
+ SavePageResult result,
+ const OfflinePageItem* item) {
DCHECK_EQ(offline_page_model_, model);
FetchOfflinePagesAndNotify();
}

Powered by Google App Engine
This is Rietveld 408576698