components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc - Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)

Patch Set: Rebase. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java ('K') | « components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h ('k') | components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc » ('j') | components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

index 8323590f2cabcfe0ac43ae28c910b5d3524eec30..2c953c4ed3617426891b9c8d0b32a003800844ca 100644

--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

@@ -208,8 +208,9 @@ void RecentTabSuggestionsProvider::

void RecentTabSuggestionsProvider::OfflinePageModelLoaded(

offline_pages::OfflinePageModel* model) {}

-void RecentTabSuggestionsProvider::OfflinePageModelChanged(

- offline_pages::OfflinePageModel* model) {

+void RecentTabSuggestionsProvider::OfflinePageAdded(

+ offline_pages::OfflinePageModel* model,

+ const offline_pages::OfflinePageItem& added_page) {

DCHECK_EQ(offline_page_model_, model);

FetchRecentTabs();

}