components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h - Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)

Patch Set: Rebase. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java ('K') | « chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc ('k') | components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc » ('j') | components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h

diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h

index fef26df081d05c4cbf6c5882217f11e5baf33e85..5ed00e9dd44cc80b789d777003ecc0878c9cf419 100644

--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h

+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h

@@ -68,7 +68,9 @@ class RecentTabSuggestionsProvider

// OfflinePageModel::Observer implementation.

void OfflinePageModelLoaded(offline_pages::OfflinePageModel* model) override;

- void OfflinePageModelChanged(offline_pages::OfflinePageModel* model) override;

+ void OfflinePageAdded(

+ offline_pages::OfflinePageModel* model,

+ const offline_pages::OfflinePageItem& added_page) override;

void OfflinePageDeleted(int64_t offline_id,

const offline_pages::ClientId& client_id) override;