Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2469893007: Reland "Adding media controls to MediaNotification" (Closed)

Created:
4 years, 1 month ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, media-router+watch_chromium.org, jam, haraken, feature-media-reviews_chromium.org, darin-cc_chromium.org, agrieve+watch_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Adding media controls to MediaNotification" Relanding this CL since it was previously reverted due to a wrong speculate on the bot. This CL adds new media controls to MediaNotification. The controls are enabled from the MediaSession API in blink, and is propagated to the browser side through mojom MediaSessionService. Then we show a corresponding button in media notification. When the user clicks the button, the event will be propagate back to the page through mojom MediaSessionClient. This CL has the following changes: * Plumb media control messages from content/ to chrome/ Java. * Add control buttons to MediaNotification Slides explaining how media controls work: https://docs.google.com/a/google.com/presentation/d/1jGNB9aT3mbpPszC3SiQnQ70CjVDmH-haomHCrqSVVAw/edit?usp=sharing Test URL: http://xxyzzzq.github.io/sandbox/media-session/full-test.html BUG=656563 TBR=kenrb@chromium.org, tedchoc@chromium.org, avayvod@chromium.org, jam@chromium.org, boliu@chromium.org TEST=MANUAL Committed: https://crrev.com/015da1aa7fe79abc631ea59ac5ed0e2a7dfb1944 Cr-Commit-Position: refs/heads/master@{#429864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -48 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/java/res/drawable-hdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java View 9 chunks +44 lines, -34 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationListener.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 9 chunks +45 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 8 chunks +37 lines, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/media/session/media_session_android.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/media/session/media_session_android.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M content/browser/media/session/media_session_impl.h View 4 chunks +21 lines, -0 lines 0 comments Download
M content/browser/media/session/media_session_impl.cc View 4 chunks +28 lines, -2 lines 0 comments Download
M content/browser/media/session/media_session_service_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/media/session/media_session_service_impl.cc View 2 chunks +29 lines, -10 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MediaSessionImpl.java View 3 chunks +20 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/MediaSession.java View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/MediaSessionObserver.java View 1 chunk +12 lines, -0 lines 0 comments Download
M content/public/browser/media_session.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/public/browser/media_session_observer.h View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469893007/1
4 years, 1 month ago (2016-11-04 10:46:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 12:11:18 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 12:13:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/015da1aa7fe79abc631ea59ac5ed0e2a7dfb1944
Cr-Commit-Position: refs/heads/master@{#429864}

Powered by Google App Engine
This is Rietveld 408576698