Unify CFWL_WidgetProperties and CFWL_WidgetImpProperties.

Unify CFWL_WidgetProperties and CFWL_WidgetImpProperties.

The CFWL_WidgetProperties class was just being used to create default
CFWL_WidgetImpProperties classes. This CL updates the code to make it clear that
we have unique_ptrs to the properties and changes CFWL_WidgetImpProperties
to be named CFWL_WidgetProperties.

Committed: https://pdfium.googlesource.com/pdfium/+/a5811f0edbaa3be7807dd84b3d4d7876289cef8a

[dsinclair, 2016-11-03 18:04:05]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 18:04:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-03 18:04:14]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-03 18:04:15]

PTAL.

[Tom Sepez, 2016-11-03 18:22:44]

lgtm

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_combo...
File xfa/fwl/core/ifwl_combobox.cpp (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_combo...
xfa/fwl/core/ifwl_combobox.cpp:696: auto propForm =
pdfium::MakeUnique<CFWL_WidgetProperties>();
nit: can this be called |formProps| ? My tiny brain parses this as 
adjective-noun so propform would be a form for props, but formprops would be
props for a form ......  or just |prop| for consistency with below?

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
File xfa/fwl/core/ifwl_datetimepicker.cpp (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.cpp:40: auto propMonth =
nit: same, monthProp.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.cpp:440: auto propForm =
pdfium::MakeUnique<CFWL_WidgetProperties>();
ditto and below.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.cpp:464: if (m_pMonthCal) {
nit: no {} while were at it.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.cpp:484: if (m_pEdit) {
nit: no {}

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_month...
File xfa/fwl/core/ifwl_monthcalendar.h (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_month...
xfa/fwl/core/ifwl_monthcalendar.h:38: class CFWL_WidgetProperties;
nit: do we need this given the include at 12

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_pictu...
File xfa/fwl/core/ifwl_picturebox.h (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_pictu...
xfa/fwl/core/ifwl_picturebox.h:30: class CFWL_WidgetProperties;
ditto

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_pushb...
File xfa/fwl/core/ifwl_pushbutton.h (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_pushb...
xfa/fwl/core/ifwl_pushbutton.h:31: class CFWL_WidgetProperties;
"

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_scrol...
File xfa/fwl/core/ifwl_scrollbar.h (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_scrol...
xfa/fwl/core/ifwl_scrollbar.h:17: class CFWL_WidgetProperties;
Probably other places where this isn't needed that I missed.

[commit-bot: I haz the power, 2016-11-03 18:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:23:39]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-03 19:10:18]

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_combo...
File xfa/fwl/core/ifwl_combobox.cpp (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_combo...
xfa/fwl/core/ifwl_combobox.cpp:696: auto propForm =
pdfium::MakeUnique<CFWL_WidgetProperties>();
On 2016/11/03 18:22:44, Tom Sepez wrote:
> nit: can this be called |formProps| ? My tiny brain parses this as 
> adjective-noun so propform would be a form for props, but formprops would be
> props for a form ......  or just |prop| for consistency with below?

Done.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
File xfa/fwl/core/ifwl_datetimepicker.cpp (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.cpp:40: auto propMonth =
On 2016/11/03 18:22:44, Tom Sepez wrote:
> nit: same, monthProp.

Done.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.cpp:440: auto propForm =
pdfium::MakeUnique<CFWL_WidgetProperties>();
On 2016/11/03 18:22:44, Tom Sepez wrote:
> ditto and below.

Done.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.cpp:464: if (m_pMonthCal) {
On 2016/11/03 18:22:44, Tom Sepez wrote:
> nit: no {} while were at it.

Done.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.cpp:484: if (m_pEdit) {
On 2016/11/03 18:22:44, Tom Sepez wrote:
> nit: no {}

Done.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_month...
File xfa/fwl/core/ifwl_monthcalendar.h (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_month...
xfa/fwl/core/ifwl_monthcalendar.h:38: class CFWL_WidgetProperties;
On 2016/11/03 18:22:44, Tom Sepez wrote:
> nit: do we need this given the include at 12

Done.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_pictu...
File xfa/fwl/core/ifwl_picturebox.h (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_pictu...
xfa/fwl/core/ifwl_picturebox.h:30: class CFWL_WidgetProperties;
On 2016/11/03 18:22:44, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_pushb...
File xfa/fwl/core/ifwl_pushbutton.h (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_pushb...
xfa/fwl/core/ifwl_pushbutton.h:31: class CFWL_WidgetProperties;
On 2016/11/03 18:22:44, Tom Sepez wrote:
> "

Done.

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_scrol...
File xfa/fwl/core/ifwl_scrollbar.h (right):

https://codereview.chromium.org/2469893004/diff/20001/xfa/fwl/core/ifwl_scrol...
xfa/fwl/core/ifwl_scrollbar.h:17: class CFWL_WidgetProperties;
On 2016/11/03 18:22:44, Tom Sepez wrote:
> Probably other places where this isn't needed that I missed.

Done.

[dsinclair, 2016-11-03 19:10:41]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-03 19:10:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2469893004/#ps40001
(title: "review cleanup")

[commit-bot: I haz the power, 2016-11-03 19:10:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 19:27:28]

Description was changed from

==========
Unify CFWL_WidgetProperties and CFWL_WidgetImpProperties.

The CFWL_WidgetProperties class was just being used to create default
CFWL_WidgetImpProperties classes. This CL updates the code to make it clear that
we have unique_ptrs to the properties and changes CFWL_WidgetImpProperties
to be named CFWL_WidgetProperties.
==========

to

==========
Unify CFWL_WidgetProperties and CFWL_WidgetImpProperties.

The CFWL_WidgetProperties class was just being used to create default
CFWL_WidgetImpProperties classes. This CL updates the code to make it clear that
we have unique_ptrs to the properties and changes CFWL_WidgetImpProperties
to be named CFWL_WidgetProperties.

Committed:
https://pdfium.googlesource.com/pdfium/+/a5811f0edbaa3be7807dd84b3d4d7876289c...
==========

[commit-bot: I haz the power, 2016-11-03 19:27:29]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/a5811f0edbaa3be7807dd84b3d4d7876289c...