Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: xfa/fwl/core/cfwl_widgetproperties.h

Issue 2469893004: Unify CFWL_WidgetProperties and CFWL_WidgetImpProperties. (Closed)
Patch Set: review cleanup Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_widgetimpproperties.h ('k') | xfa/fwl/core/cfwl_widgetproperties.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/cfwl_widgetproperties.h
diff --git a/xfa/fwl/core/cfwl_widgetproperties.h b/xfa/fwl/core/cfwl_widgetproperties.h
index afadfc49f1afd7c29087dd2f187b422fe6c23d7d..21040b9ee915f75d2cc6a1bee53fdf2acdf5a33a 100644
--- a/xfa/fwl/core/cfwl_widgetproperties.h
+++ b/xfa/fwl/core/cfwl_widgetproperties.h
@@ -8,30 +8,46 @@
#define XFA_FWL_CORE_CFWL_WIDGETPROPERTIES_H_
#include "core/fxcrt/fx_coordinates.h"
-#include "core/fxcrt/fx_string.h"
#include "core/fxcrt/fx_system.h"
-#include "xfa/fwl/core/cfwl_widgetimpproperties.h"
+#include "xfa/fwl/core/fwl_widgetdef.h"
-class CFWL_Widget;
class IFWL_DataProvider;
+class IFWL_ThemeProvider;
+class IFWL_Widget;
class CFWL_WidgetProperties {
public:
CFWL_WidgetProperties();
+ CFWL_WidgetProperties(IFWL_DataProvider* dataProvider);
~CFWL_WidgetProperties();
- CFWL_WidgetProperties(const CFWL_WidgetProperties& other);
- CFWL_WidgetImpProperties MakeWidgetImpProperties(
- IFWL_DataProvider* pDataProvider) const;
-
- CFX_WideString m_wsWindowclass;
CFX_Matrix m_ctmOnParent;
CFX_RectF m_rtWidget;
uint32_t m_dwStyles;
uint32_t m_dwStyleExes;
uint32_t m_dwStates;
- CFWL_Widget* m_pParent;
- CFWL_Widget* m_pOwner;
+ IFWL_ThemeProvider* m_pThemeProvider;
+ IFWL_DataProvider* m_pDataProvider;
+ IFWL_Widget* m_pParent;
+ IFWL_Widget* m_pOwner;
};
+inline CFWL_WidgetProperties::CFWL_WidgetProperties()
+ : CFWL_WidgetProperties(nullptr) {}
+
+inline CFWL_WidgetProperties::CFWL_WidgetProperties(
+ IFWL_DataProvider* dataProvider)
+ : m_dwStyles(FWL_WGTSTYLE_Child),
+ m_dwStyleExes(0),
+ m_dwStates(0),
+ m_pThemeProvider(nullptr),
+ m_pDataProvider(dataProvider),
+ m_pParent(nullptr),
+ m_pOwner(nullptr) {
+ m_ctmOnParent.SetIdentity();
+ m_rtWidget.Set(0, 0, 0, 0);
+}
+
+inline CFWL_WidgetProperties::~CFWL_WidgetProperties() {}
+
#endif // XFA_FWL_CORE_CFWL_WIDGETPROPERTIES_H_
« no previous file with comments | « xfa/fwl/core/cfwl_widgetimpproperties.h ('k') | xfa/fwl/core/cfwl_widgetproperties.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698