Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2469863009: Re-enable iOS testing (Closed)

Created:
4 years, 1 month ago by stephana
Modified:
4 years, 1 month ago
Reviewers:
dogben
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M infra/bots/recipes/swarm_trigger.py View 1 1 chunk +5 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.json View 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
stephana
4 years, 1 month ago (2016-11-04 14:07:36 UTC) #4
dogben
lgtm :-( https://codereview.chromium.org/2469863009/diff/1/infra/bots/recipes/swarm_trigger.py File infra/bots/recipes/swarm_trigger.py (right): https://codereview.chromium.org/2469863009/diff/1/infra/bots/recipes/swarm_trigger.py#newcode143 infra/bots/recipes/swarm_trigger.py:143: 'iPad4': 'iPad5,1', Please add a comment.
4 years, 1 month ago (2016-11-04 14:12:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469863009/1
4 years, 1 month ago (2016-11-04 14:28:43 UTC) #7
stephana
https://codereview.chromium.org/2469863009/diff/1/infra/bots/recipes/swarm_trigger.py File infra/bots/recipes/swarm_trigger.py (right): https://codereview.chromium.org/2469863009/diff/1/infra/bots/recipes/swarm_trigger.py#newcode143 infra/bots/recipes/swarm_trigger.py:143: 'iPad4': 'iPad5,1', On 2016/11/04 14:12:01, dogben wrote: > Please ...
4 years, 1 month ago (2016-11-04 14:33:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469863009/20001
4 years, 1 month ago (2016-11-04 15:02:13 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 15:35:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/37be4d013520906891c1a0908874314d1fdce265

Powered by Google App Engine
This is Rietveld 408576698