Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: infra/bots/recipes/swarm_trigger.py

Issue 2469863009: Re-enable iOS testing (Closed)
Patch Set: Added comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipes/swarm_trigger.py
diff --git a/infra/bots/recipes/swarm_trigger.py b/infra/bots/recipes/swarm_trigger.py
index 41470eba687d778256571f66aaefce553a571fd4..2547c79b97af1e2a3d9c868b9c6abb3f0d0097e9 100644
--- a/infra/bots/recipes/swarm_trigger.py
+++ b/infra/bots/recipes/swarm_trigger.py
@@ -140,10 +140,13 @@ def swarm_dimensions(builder_cfg):
elif 'iOS' in builder_cfg['os']:
# For iOS, the device type is a better dimension than CPU or GPU.
dimensions['device'] = {
- 'iPad4': 'iPad4,1',
+ # TODO(stephana): Remove this temporary discrepancy between the bot name
+ # and device. When we expand iOS testing names and devices need to match
+ # again.
+ 'iPad4': 'iPad5,1',
}[builder_cfg['model']]
# TODO(borenet): Replace this hack with something better.
- dimensions['os'] = 'iOS-9.2'
+ dimensions['os'] = 'iOS-9.3.1'
elif builder_cfg['cpu_or_gpu'] == 'CPU':
dimensions['gpu'] = 'none'
dimensions['cpu'] = {
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698