Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2469813004: Rename CPDFXFA_Document to CPDFXFA_Context (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename CPDFXFA_Document to CPDFXFA_Context The CPDFXFA_Document class isn't a document, it contains documents. Renamed to make the purpose a bit clearer. Committed: https://pdfium.googlesource.com/pdfium/+/521b7508dfe8ab93975eeb9f4ef8068012c4dbd8

Patch Set 1 #

Patch Set 2 : Merge to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -896 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_annot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 11 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 11 chunks +33 lines, -31 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 11 chunks +28 lines, -28 lines 0 comments Download
M fpdfsdk/fpdftext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cpdfxfa_context.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cpdfxfa_context.cpp View 1 16 chunks +37 lines, -37 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 30 chunks +125 lines, -130 lines 0 comments Download
D fpdfsdk/fpdfxfa/cpdfxfa_document.h View 1 chunk +0 lines, -116 lines 0 comments Download
D fpdfsdk/fpdfxfa/cpdfxfa_document.cpp View 1 1 chunk +0 lines, -460 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_page.h View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_page.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
M fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_define.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_checkbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
dsinclair
PTAL. I think this makes more sense as a name. I'd like to try to ...
4 years, 1 month ago (2016-11-02 14:07:02 UTC) #2
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-02 19:24:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469813004/20001
4 years, 1 month ago (2016-11-02 19:47:47 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 20:02:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/521b7508dfe8ab93975eeb9f4ef8068012c4...

Powered by Google App Engine
This is Rietveld 408576698