Merge CPDFXFA_App into CPDFXFA_Document.

Merge CPDFXFA_App into CPDFXFA_Document.

This Cl moves the CPDFXFA_App code into CPDFXFA_Document.

Committed: https://pdfium.googlesource.com/pdfium/+/25ec646b2c128a6beaa961ec2b2eeb673ed034ca

[dsinclair, 2016-10-17 19:00:08]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 19:00:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 19:01:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:01:46]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/2496)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)
  win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_clang/b...)

[dsinclair, 2016-11-02 12:58:56]

Description was changed from

==========
Merge CPDFXFA_App into CPDFXFA_Document.

This Cl moves the CPDFXFA_App code into CPDFXFA_Document.
==========

to

==========
Merge CPDFXFA_App into CPDFXFA_Document.

This Cl moves the CPDFXFA_App code into CPDFXFA_Document.
==========

[dsinclair, 2016-11-02 13:28:29]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-11-02 13:28:31]

PTAL.

[dsinclair, 2016-11-02 14:00:32]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 14:00:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 14:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 14:13:56]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-02 19:19:35]

lgtm

https://codereview.chromium.org/2424993002/diff/60001/fpdfsdk/fpdfxfa/cpdfxfa...
File fpdfsdk/fpdfxfa/cpdfxfa_document.cpp (right):

https://codereview.chromium.org/2424993002/diff/60001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_document.cpp:50: CloseXFADoc();
Maybe CloseXFADoc() should make this check itself and we always call it here.

[dsinclair, 2016-11-02 19:22:34]

https://codereview.chromium.org/2424993002/diff/60001/fpdfsdk/fpdfxfa/cpdfxfa...
File fpdfsdk/fpdfxfa/cpdfxfa_document.cpp (right):

https://codereview.chromium.org/2424993002/diff/60001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_document.cpp:50: CloseXFADoc();
On 2016/11/02 19:19:34, Tom Sepez wrote:
> Maybe CloseXFADoc() should make this check itself and we always call it here.

Done.

[dsinclair, 2016-11-02 19:22:37]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-02 19:22:38]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2424993002/#ps80001
(title: "Move check")

[commit-bot: I haz the power, 2016-11-02 19:22:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 19:37:17]

Description was changed from

==========
Merge CPDFXFA_App into CPDFXFA_Document.

This Cl moves the CPDFXFA_App code into CPDFXFA_Document.
==========

to

==========
Merge CPDFXFA_App into CPDFXFA_Document.

This Cl moves the CPDFXFA_App code into CPDFXFA_Document.

Committed:
https://pdfium.googlesource.com/pdfium/+/25ec646b2c128a6beaa961ec2b2eeb673ed0...
==========

[commit-bot: I haz the power, 2016-11-02 19:37:18]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/25ec646b2c128a6beaa961ec2b2eeb673ed0...